From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932782AbcAYOz1 (ORCPT ); Mon, 25 Jan 2016 09:55:27 -0500 Received: from mail-lb0-f171.google.com ([209.85.217.171]:33534 "EHLO mail-lb0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932749AbcAYOzU (ORCPT ); Mon, 25 Jan 2016 09:55:20 -0500 Subject: Re: [PATCH 1/3] printk: make preferred_console local static bool To: Andy Shevchenko References: <1453722324-22407-1-git-send-email-aleksey.makarov@linaro.org> <1453722324-22407-2-git-send-email-aleksey.makarov@linaro.org> Cc: "linux-acpi@vger.kernel.org" , "linux-kernel@vger.kernel.org" , linux-arm Mailing List , "linux-serial@vger.kernel.org" , Graeme Gregory , Russell King , Greg Kroah-Hartman , "Rafael J . Wysocki" , Leif Lindholm From: Aleksey Makarov Message-ID: <56A63754.7030108@linaro.org> Date: Mon, 25 Jan 2016 20:55:16 +0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 25.01.2016 20:24, Andy Shevchenko wrote: > On Mon, Jan 25, 2016 at 1:45 PM, Aleksey Makarov > wrote: >> The variable preferred_console is used only inside register_console() >> and it's semantics is boolean. Make it clear. > > However the patch looks okay it brings imbalance to understanding how > exactly the preferred console is chosen. On the contrary, I would say it makes things more clear. Also please consider this patch preparatory for the further changes. See my replies to Joe Perches.