From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757256AbcAYPHU (ORCPT ); Mon, 25 Jan 2016 10:07:20 -0500 Received: from mail-lf0-f45.google.com ([209.85.215.45]:34531 "EHLO mail-lf0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756025AbcAYPHR (ORCPT ); Mon, 25 Jan 2016 10:07:17 -0500 Subject: Re: [PATCH 2/3] ACPI: parse SPCR and enable matching console To: Andy Shevchenko References: <1453722324-22407-1-git-send-email-aleksey.makarov@linaro.org> <1453722324-22407-3-git-send-email-aleksey.makarov@linaro.org> Cc: "linux-acpi@vger.kernel.org" , "linux-kernel@vger.kernel.org" , linux-arm Mailing List , "linux-serial@vger.kernel.org" , Graeme Gregory , Russell King , Greg Kroah-Hartman , "Rafael J . Wysocki" , Leif Lindholm , Catalin Marinas , Will Deacon , Len Brown From: Aleksey Makarov Message-ID: <56A63A20.4040602@linaro.org> Date: Mon, 25 Jan 2016 21:07:12 +0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 25.01.2016 20:14, Andy Shevchenko wrote: > On Mon, Jan 25, 2016 at 1:45 PM, Aleksey Makarov > wrote: >> 'ARM Server Base Boot Requiremets' [1] mention SPCR >> (Serial Port Console Redirection Table) [2] as a mandatory ACPI table >> that specifies the configuration of serial console. >> >> Parse this table and check if any registered console match >> the description. If it does, enable that console. >> >> To implement that, introduce a new member >> int (*acpi_match)(struct console *, struct acpi_table_spcr *) >> of struct console. It allows drivers to check if they provide >> a matching console device. >> >> [1] http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.den0044a/index.html >> [2] http://msdn.microsoft.com/en-us/library/windows/hardware/dn639131(v=vs.85).aspx > > Can you split this to several patches? I am not sure I should. > I see preparatory patch in console code, i.e. > delete_from_console_list(), adding SPCR support to ACPI, enabling it. It would be difficult to justify delete_from_console_list() in a separate patches before the rest of the changes. And enabling SPCR in a separate patch also looks oddly for me. It would be great to have other comments on this before I fix this in the next version. Thank you