From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757342AbcAYQZG (ORCPT ); Mon, 25 Jan 2016 11:25:06 -0500 Received: from prod-mail-xrelay05.akamai.com ([23.79.238.179]:38980 "EHLO prod-mail-xrelay05.akamai.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755960AbcAYQZD (ORCPT ); Mon, 25 Jan 2016 11:25:03 -0500 Subject: Re: 3.14 stable regression don't remove from shrink list in select_collect() To: Shawn Bohrer , viro@zeniv.linux.org.uk References: <20160125160505.GA7834@sbohrermbp13-local.rgmadvisors.com> Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, nab@linux-iscsi.org, gregkh@linuxfoundation.org, Guillaume Morin From: Jason Baron Message-ID: <56A64C5D.2060104@akamai.com> Date: Mon, 25 Jan 2016 11:25:01 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <20160125160505.GA7834@sbohrermbp13-local.rgmadvisors.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/25/2016 11:05 AM, Shawn Bohrer wrote: > I recently updated some machines to 3.14.58 and they reliably get soft > lockups. Sometimes the soft lockup recovers and some times it does > not. I've bisected this on the 3.14 stable branch and arrived at: > > c214cb82cdc744225d85899fc138251527f75fff don't remove from shrink > list in select_collect() > > Reverting this commit plus adding back dentry_lru_del() which was > removed later on top of 3.14.58 resolves the issue for me. I've > included a patch at the bottom with the revert. > I ran into this too on 3.14. You can revert these patches as you've done or backport the upstream fixes mentioned here: http://www.spinics.net/lists/stable/msg111544.html I don't see these fixes queued yet to 3.14, but I may be missing something. Thanks, -Jason