From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932597AbcAZAqd (ORCPT ); Mon, 25 Jan 2016 19:46:33 -0500 Received: from mailout2.w1.samsung.com ([210.118.77.12]:36709 "EHLO mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755882AbcAZAqa (ORCPT ); Mon, 25 Jan 2016 19:46:30 -0500 X-AuditID: cbfec7f5-f79b16d000005389-fb-56a6c1e41d0d Subject: Re: [PATCH] fbdev: s6e8ax0: avoid unused function warnings To: Arnd Bergmann , Tomi Valkeinen References: <1453734300-1958304-1-git-send-email-arnd@arndb.de> Cc: linux-arm-kernel@lists.infradead.org, Jean-Christophe Plagniol-Villard , Kukjin Kim , linux-fbdev@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org From: Krzysztof Kozlowski X-Enigmail-Draft-Status: N1110 Message-id: <56A6C1E2.7060804@samsung.com> Date: Tue, 26 Jan 2016 09:46:26 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-version: 1.0 In-reply-to: <1453734300-1958304-1-git-send-email-arnd@arndb.de> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrOLMWRmVeSWpSXmKPExsVy+t/xq7pPDi4LM2hbq2zxd9IxdovXLwwt +h+/ZrbY9Pgaq8WJvg+sFpd3zWGzmHF+H5PFuocvmCzWz7/F5sDp8fvXJEaPVxfusHhsWtXJ 5rF5Sb1H35ZVjB7Hb2xn8vi8SS6APYrLJiU1J7MstUjfLoEr4+alB8wFk9grXvV3sjYw/mft YuTgkBAwkdi8XK+LkRPIFJO4cG89WxcjF4eQwFJGiY77GxkhnKeMEn0/57ODVAkLOEs03lrI CGKLCHhK3Ps3AywuJGAvsXnLe7AGZpCG178mgBWxCRgDbVjCBrFCTqK3exILiM0roCXxftt0 JhCbRUBVonUqyEWcHKICERKHO7vYIWoEJX5MvscCcimngIPEwrn8ICazgJ7E/YtaIBXMAvIS m9e8ZZ7AKDgLScMshKpZSKoWMDKvYhRNLU0uKE5KzzXSK07MLS7NS9dLzs/dxAiJjq87GJce szrEKMDBqMTDy1m8LEyINbGsuDL3EKMEB7OSCO/evUAh3pTEyqrUovz4otKc1OJDjNIcLEri vDN3vQ8REkhPLEnNTk0tSC2CyTJxcEo1MF7/XHbAcq1X5g3T9bUXOrRLXn4MZZM0X328OP6V xxGR3Qse8+ltU9h/4lyumqBW+JLNpjeylt+dPyvq4Ra/lok3Yhe7nTvKtjDeweNaduQP5fMG v74teL8vNHzm/yebDTPv8AuG2s42+vs5LSXZ6zm/4pw9+2X+PL+4fFPOfackiUdsz5VOf72k xFKckWioxVxUnAgAihgAO4oCAAA= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 26.01.2016 00:04, Arnd Bergmann wrote: > The s6e8ax0 suspend/resume functions are hidden inside of an #ifdef > when CONFIG_PM is set to avoid unused function warnings, but they > call some other functions that nothing else calls, and we get warnings > about those: > > drivers/video/fbdev/exynos/s6e8ax0.c:449:13: error: 's6e8ax0_sleep_in' defined but not used [-Werror=unused-function] > drivers/video/fbdev/exynos/s6e8ax0.c:485:13: error: 's6e8ax0_display_off' defined but not used [-Werror=unused-function] > > This marks the PM functions as __maybe_unused so the compiler can > silently drop them when they are not referenced. > > Signed-off-by: Arnd Bergmann > --- > drivers/video/fbdev/exynos/s6e8ax0.c | 13 ++++--------- > 1 file changed, 4 insertions(+), 9 deletions(-) > Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof