From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965072AbcAZKb3 (ORCPT ); Tue, 26 Jan 2016 05:31:29 -0500 Received: from a.ns.miles-group.at ([95.130.255.143]:11950 "EHLO radon.swed.at" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933294AbcAZKbX (ORCPT ); Tue, 26 Jan 2016 05:31:23 -0500 Subject: Re: [PATCH 03/22] scsi: Fix dependencies for !HAS_IOMEM and !HAS_DMA archs To: John Garry , linux-kernel@vger.kernel.org References: <1453760661-1444-1-git-send-email-richard@nod.at> <1453760661-1444-4-git-send-email-richard@nod.at> <56A74743.6000308@huawei.com> Cc: user-mode-linux-devel@lists.sourceforge.net, "James E.J. Bottomley" , "Martin K. Petersen" , linux-scsi@vger.kernel.org, Geert Uytterhoeven From: Richard Weinberger Message-ID: <56A74AF6.90307@nod.at> Date: Tue, 26 Jan 2016 11:31:18 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <56A74743.6000308@huawei.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 26.01.2016 um 11:15 schrieb John Garry: > On 25/01/2016 22:24, Richard Weinberger wrote: >> Not every arch has io or DMA memory. >> So, unbreak the build by fixing the dependencies. >> >> Signed-off-by: Richard Weinberger >> --- >> drivers/scsi/hisi_sas/Kconfig | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/scsi/hisi_sas/Kconfig b/drivers/scsi/hisi_sas/Kconfig >> index 37a0c71..f9157f4 100644 >> --- a/drivers/scsi/hisi_sas/Kconfig >> +++ b/drivers/scsi/hisi_sas/Kconfig >> @@ -2,5 +2,6 @@ config SCSI_HISI_SAS >> tristate "HiSilicon SAS" >> select SCSI_SAS_LIBSAS >> select BLK_DEV_INTEGRITY >> + depends on HAS_IOMEM && HAS_DMA >> help >> This driver supports HiSilicon's SAS HBA >> > > I think that there is already a fix for depencencies from Geert: > http://git.kernel.org/cgit/linux/kernel/git/jejb/scsi.git/log/?h=fixes Hmm, right. But we still need HAS_IOMEM too. Thanks, //richard