From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965560AbcAZMuG (ORCPT ); Tue, 26 Jan 2016 07:50:06 -0500 Received: from mail1.bemta12.messagelabs.com ([216.82.251.12]:13384 "EHLO mail1.bemta12.messagelabs.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932339AbcAZMt6 convert rfc822-to-8bit (ORCPT ); Tue, 26 Jan 2016 07:49:58 -0500 X-Greylist: delayed 426 seconds by postgrey-1.27 at vger.kernel.org; Tue, 26 Jan 2016 07:49:58 EST X-Env-Sender: hehy1@lenovo.com X-Msg-Ref: server-7.tower-190.messagelabs.com!1453812168!15451088!1 X-Originating-IP: [103.30.232.71] X-StarScan-Received: X-StarScan-Version: 7.35.1; banners=-,-,- X-VirusChecked: Checked From: Ocean HY1 He To: One Thousand Gnomes CC: "tj@kernel.org" , "linux-ide@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] Let AHCI dirver skip Lenovo SWRAID controller Thread-Topic: [PATCH] Let AHCI dirver skip Lenovo SWRAID controller Thread-Index: AQHRVx4cydGblwaO1UiWKYZ2uxK2IJ8LsYMAgAGIC4A= Date: Tue, 26 Jan 2016 12:42:43 +0000 Message-ID: <56A76999.8050206@lenovo.com> References: <1453691440-42035-1-git-send-email-hehy1@lenovo.com> <20160125131850.64c5c22a@lxorguk.ukuu.org.uk> In-Reply-To: <20160125131850.64c5c22a@lxorguk.ukuu.org.uk> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.96.19.89] Content-Type: text/plain; charset="Windows-1252" Content-ID: Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Alan, Thanks for your comments! Lenovo SWRAID driver is a closed source driver at this time, I am afraid it's not possible to submit it to kernel. This patch is very important and critical for Lenovo next generation Servers. I have tried to make sure this patch only impacts Lenovo dedicated hardware and add a on/off boot option to end user who may still wants using open source SWRAID(such as MDRAID). I am a newbie to submit patch to kernel, so I am not so clear about what my patch breaks. Could you kindly explain that and is there a workaround or solution to avoid the break? Thanks a lot! Ocean. On 01/25/2016 09:18 PM, One Thousand Gnomes wrote: > On Mon, 25 Jan 2016 03:11:40 +0000 > Ocean HY1 He wrote: > >> Lenovo SWRAID solution is based on Intel Non-RSTE RAID controller which >> is called Lenovo SWRAID controller by set Lenovo dedicated PCI >> SVID:SDID. >> >> Because AHCI driver now take control this Lenovo SWRAID controller for >> MDRAID, Lenovo SWRAID driver fails to load later. It's not proper to >> disable AHCI driver, because system has SATA contoller used for SATA >> DVD, M.2 etc. There is no chance to load Lenovo SWRAID first, because >> almost all Linux distros load AHCI driver first during installation. >> >> As default, when Lenovo SWRAID controller is detected, let AHCI driver >> skip it thus MDRAID is disabled. Use the boot option 'ahci.lenovo_swraid=0' >> could disable Lenovo SWRAID. > > You need to submit the Lenovo SWRAID driver to the kernel first. > Otherwise this breaks things. > > Alan >