From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966490AbcAZPOf (ORCPT ); Tue, 26 Jan 2016 10:14:35 -0500 Received: from mx-rz-1.rrze.uni-erlangen.de ([131.188.11.20]:48292 "EHLO mx-rz-1.rrze.uni-erlangen.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932442AbcAZPOd (ORCPT ); Tue, 26 Jan 2016 10:14:33 -0500 X-RRZE-Submit-IP: 2001:638:a000:4142::ff0f:d304 Subject: Re: [PATCH] cgroup: Fix misspelling of CONFIG_SOCK_CGROUP_DATA in comments To: "Rosen, Rami" , Tejun Heo References: <1453819158-25380-1-git-send-email-andreas.ziegler@fau.de> <9B0331B6EBBD0E4684FBFAEDA55776F92CB53E91@HASMSX110.ger.corp.intel.com> Cc: Li Zefan , Johannes Weiner , "cgroups@vger.kernel.org" , "linux-kernel@vger.kernel.org" From: Andreas Ziegler Message-ID: <56A78D56.2030902@fau.de> Date: Tue, 26 Jan 2016 16:14:30 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <9B0331B6EBBD0E4684FBFAEDA55776F92CB53E91@HASMSX110.ger.corp.intel.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/26/2016 16:08, Rosen, Rami wrote: > Hi, > > --- a/include/linux/cgroup.h > +++ b/include/linux/cgroup.h > @@ -604,11 +604,11 @@ static inline struct cgroup *sock_cgroup_ptr(struct sock_cgroup_data *skcd) > #endif > } > > In this occasion, seems that maybe something else is also missing: > Shouldn't it be hereafter : +#else /* !CONFIG_SOCK_CGROUP_DATA */ > instead ? > > -#else /* CONFIG_CGROUP_DATA */ > +#else /* CONFIG_SOCK_CGROUP_DATA */ It seems that there is no real consensus among the developers for that particular case: ziegler@box:~/linux$ git grep "#else \/\* \!CONFIG_" | wc -l 327 ziegler@box:~/linux$ git grep "#else \/\* CONFIG_" | wc -l 564 I don't mind changing it, I'm just not sure if that's what we want. Regards, Andreas