From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753108AbcA0ByF (ORCPT ); Tue, 26 Jan 2016 20:54:05 -0500 Received: from lists.s-osg.org ([54.187.51.154]:54295 "EHLO lists.s-osg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752569AbcA0ByC (ORCPT ); Tue, 26 Jan 2016 20:54:02 -0500 Subject: Re: [PATCH v3 07/10] rtc: max77686: Use dev_warn() instead of pr_warn() To: Andi Shyti References: <1453836020-29579-1-git-send-email-javier@osg.samsung.com> <1453836020-29579-8-git-send-email-javier@osg.samsung.com> <20160127012230.GE14296@samsunx.samsung> Cc: linux-kernel@vger.kernel.org, Kukjin Kim , rtc-linux@googlegroups.com, Chanwoo Choi , Alexandre Belloni , Krzysztof Kozlowski , Laxman Dewangan , linux-samsung-soc@vger.kernel.org From: Javier Martinez Canillas Message-ID: <56A82331.5050403@osg.samsung.com> Date: Tue, 26 Jan 2016 22:53:53 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 MIME-Version: 1.0 In-Reply-To: <20160127012230.GE14296@samsunx.samsung> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Andi, Thanks a lot for your feedback and review. On 01/26/2016 10:22 PM, Andi Shyti wrote: > Hi Javier, > >> if (tm->tm_year < 100) { >> - pr_warn("RTC can't handle year %d. Assume it's 2000.\n", >> - 1900 + tm->tm_year); >> + dev_warn(info->dev, >> + "RTC can't handle year %d. Assume it's 2000\n", >> + 1900 + tm->tm_year); >> return -EINVAL; > > Because we are returning an error value, why not use dev_err()? > You are absolutely right. Since the driver was using pr_warn(), I used dev_warn() but dev_err() would had been correct. If you don't mind I plan to do it as a follow up patch to avoid having to resend the whole series only for this change. Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America