From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752361AbcA0EY2 (ORCPT ); Tue, 26 Jan 2016 23:24:28 -0500 Received: from mailout4.w1.samsung.com ([210.118.77.14]:56465 "EHLO mailout4.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751021AbcA0EY0 (ORCPT ); Tue, 26 Jan 2016 23:24:26 -0500 X-AuditID: cbfec7f4-f79026d00000418a-ac-56a84677e966 Subject: Re: [PATCH v4 07/10] rtc: max77686: Fix unsupported year message To: Javier Martinez Canillas , linux-kernel@vger.kernel.org References: <1453865806-4661-1-git-send-email-javier@osg.samsung.com> <1453865806-4661-8-git-send-email-javier@osg.samsung.com> Cc: Kukjin Kim , rtc-linux@googlegroups.com, Andi Shyti , Chanwoo Choi , Alexandre Belloni , Laxman Dewangan , linux-samsung-soc@vger.kernel.org From: Krzysztof Kozlowski Message-id: <56A84673.5040806@samsung.com> Date: Wed, 27 Jan 2016 13:24:19 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-version: 1.0 In-reply-to: <1453865806-4661-8-git-send-email-javier@osg.samsung.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrMLMWRmVeSWpSXmKPExsVy+t/xK7rlbivCDPqucVh0XFvMZLH9yDNW i+tfnrNavHm7hsni9QtDi/7Hr5ktlu5bzWJxedccNosZ5/cxWezv7GB04PJ4sukio8eeiSfZ PDat6mTz6G1+x+axpf8uu0ffllWMHp83yQWwR3HZpKTmZJalFunbJXBl3Jv/krngElfFpgm6 DYzbOboYOTkkBEwkti86wQJhi0lcuLeerYuRi0NIYCmjxOFj91ghnKeMEg0z5zKBVAkLeEps OfWPDcQWEQiV+HfxNiNEUSOjxKWJT8DamQUmM0m8be0Dq2ITMJbYvHwJmM0roCWxoKeRFcRm EVCVmPhiGdhUUYEIicOdXewQNYISPybfA7uJU8BN4uS9fqA4B9BQPYn7F7VAwswC8hKb17xl nsAoMAtJxyyEqllIqhYwMq9iFE0tTS4oTkrPNdQrTswtLs1L10vOz93ECImKLzsYFx+zOsQo wMGoxMN7Y//yMCHWxLLiytxDjBIczEoivOJ2K8KEeFMSK6tSi/Lji0pzUosPMUpzsCiJ887d 9T5ESCA9sSQ1OzW1ILUIJsvEwSnVwLhA6MGpWYKf/4hXVrnd/ca30Ttw4X5fgSNWiv0tu33W x3S/8NjN9t7oxv4uGYadFsckfJ08Q96Ur42RLjlVtclVN26WQI2+pkTAlWUCmRdb8yp/7bze 4pAqXimd3t7m5Zh2fUm07uvyz+y75x21mvx8YuLXHaqyG5dErLNXvPR4Q31/yvH/W5VYijMS DbWYi4oTAUT7ncmGAgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 27.01.2016 12:36, Javier Martinez Canillas wrote: > The max77686 RTC only supports a range of 99 years so instead of using > year 1900 as the base, the year 2000 is used. This means that 1900 to > 1999 are unsupported years. > > The driver was printing a warning for those values but was returning a > error so for consistency, print an error message instead and don't say > that a year 2000 is assumed, since the year is not set. > > Also, it is better to use dev_* log functions instead of pr_* to print > information about the device in the kernel log in a standardized way. > > This also allows to remove the local pr_fmt() defined macro. > > Suggested-by: Krzysztof Kozlowski > Signed-off-by: Javier Martinez Canillas > > --- > > Changes in v4: > - Use dev_err() instead of dev_warn() and change message. > Suggested by Krzysztof Kozlowski and Andi Shyti. > - Change subject line and commit message of patch #7. > - Removed Laxman Dewangan's Acked-by tag since the patch changed. > > Changes in v3: > - Add Laxman Dewangan's Acked-by tag to patch #7. > > Changes in v2: None > > drivers/rtc/rtc-max77686.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof