From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753775AbcA0HHA (ORCPT <rfc822;w@1wt.eu>);
	Wed, 27 Jan 2016 02:07:00 -0500
Received: from comal.ext.ti.com ([198.47.26.152]:60133 "EHLO comal.ext.ti.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751046AbcA0HG6 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Wed, 27 Jan 2016 02:06:58 -0500
Subject: Re: [PATCH] mm: fix pfn_t to page conversion in vm_insert_mixed
To: Dan Williams <dan.j.williams@intel.com>, <dri-devel@lists.freedesktop.org>
References: <20160126183751.9072.22772.stgit@dwillia2-desk3.amr.corp.intel.com>
CC: Dave Hansen <dave@sr71.net>, David Airlie <airlied@linux.ie>,
        <linux-kernel@vger.kernel.org>, Julian Margetson <runaway@candw.ms>,
        <linux-mm@kvack.org>, <akpm@linux-foundation.org>
From: Tomi Valkeinen <tomi.valkeinen@ti.com>
Message-ID: <56A86C7D.6080708@ti.com>
Date: Wed, 27 Jan 2016 09:06:37 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.5.1
MIME-Version: 1.0
In-Reply-To: <20160126183751.9072.22772.stgit@dwillia2-desk3.amr.corp.intel.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature";
	boundary="BiOdgKC1QB4OaMKo6JHuvhfGFbdlLLEjN"
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

--BiOdgKC1QB4OaMKo6JHuvhfGFbdlLLEjN
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable


On 26/01/16 20:37, Dan Williams wrote:
> pfn_t_to_page() honors the flags in the pfn_t value to determine if a
> pfn is backed by a page.  However, vm_insert_mixed() was originally
> written to use pfn_valid() to make this determination.  To restore the
> old/correct behavior, ignore the pfn_t flags in the !pfn_t_devmap() cas=
e
> and fallback to trusting pfn_valid().
>=20
> Fixes: 01c8f1c44b83 ("mm, dax, gpu: convert vm_insert_mixed to pfn_t")

Thanks, this fixes the crash with omapdrm.

Tested-by: Tomi Valkeinen <tomi.valkeinen@ti.com>

 Tomi


--BiOdgKC1QB4OaMKo6JHuvhfGFbdlLLEjN
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBCAAGBQJWqGx9AAoJEPo9qoy8lh71hkQP/jMqrvyEt5BTGxhouxeSpUE+
kIL+fJFVRpfeE+QO3bXRFyuXt6NoT9F+IGzPDBtEJHnc/7vdyDVpLoI+bP9PpqJM
R6faTLy2aE+7XG/2JrtUtk1XepsHyl4yOMEd3vpKh60PIAc+YhEC0PCDOgoyJnHW
XOlhNoloY/bIBP1NHwbK3ZgR70KIhCBQlAxRqlNp1c2LgHr7weriCzMhD8COOYsk
93VjZ/Az4VSkRGbmGyL+lFk9VEzhPpypE4JzPHG1+lYT8T0eyd8s1RLwaOjJ66gW
6WSvVgcb/jgu2m30gClcx8ZSOwSXDgG7aDyo6oMwUucoF3zNwJvG9q99Q0PI4Z8M
gfBighuQaGZWATNWRuJyA6ef6VkXto4IuYPnzlSs1DA+7gSS3tSg2plp1/Xuykt2
1RvKkiI2sFqs2X8Z3uVDwNLofvGrvdiSrMiRraWwaiyvA0nlaryR7qx8FOYbOZhK
wJB4CPu0hGCd+tah2/wfvwGCcN9vCNXrxH4vzBOkmd2wxfBVfJWopDvh1sqg+DsW
zn9ohbu/Cjr1h4EVwxlsm3oFaFTG6JrxIy02bj2V4NycM20tfy1D0mi0bBlrzaYB
w7Qs8PBZbEHodt8gy7m5VNWB/y0q2AnlTbLiYVrVIZ/YEc/vCPjMcX30D9Q+SGEB
igPIEJDBcy+xWy04IuIg
=vPcr
-----END PGP SIGNATURE-----

--BiOdgKC1QB4OaMKo6JHuvhfGFbdlLLEjN--