From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935329AbcA1AAe (ORCPT ); Wed, 27 Jan 2016 19:00:34 -0500 Received: from lists.s-osg.org ([54.187.51.154]:55901 "EHLO lists.s-osg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750835AbcA1AAb (ORCPT ); Wed, 27 Jan 2016 19:00:31 -0500 Subject: Re: [PATCH] rtc: max77686: Cleanup and reduce dmesg output To: Krzysztof Kozlowski , Chanwoo Choi , Alessandro Zummo , Alexandre Belloni , linux-kernel@vger.kernel.org, rtc-linux@googlegroups.com References: <1453877171-30510-1-git-send-email-k.kozlowski@samsung.com> Cc: Andi Shyti , Laxman Dewangan From: Javier Martinez Canillas Message-ID: <56A95A17.2070900@osg.samsung.com> Date: Wed, 27 Jan 2016 21:00:23 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 MIME-Version: 1.0 In-Reply-To: <1453877171-30510-1-git-send-email-k.kozlowski@samsung.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Krzysztof, On 01/27/2016 03:46 AM, Krzysztof Kozlowski wrote: > Cleanup of entire driver of its dmesg output: > 1. Remove printing of the function name, because printing device name is > sufficient. This also makes the dev_err()-like functions more compact > and readable (not need of line break). > 2. Lower from info to debug printing of each RTC interrupt (no need to > make noise on each alarm). > 3. Remove dev_info() at beginning of probe because a message is already > always printed by either probe failure or from registering the RTC > device as /dev/rtcX. > > Signed-off-by: Krzysztof Kozlowski > Patch looks good to me. Reviewed-by: Javier Martinez Canillas Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America