From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935782AbcA1BXP (ORCPT ); Wed, 27 Jan 2016 20:23:15 -0500 Received: from mailout3.samsung.com ([203.254.224.33]:54909 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933183AbcA1BXK (ORCPT ); Wed, 27 Jan 2016 20:23:10 -0500 MIME-version: 1.0 Content-type: text/plain; charset=UTF-8 X-AuditID: cbfee68d-f79646d000001355-1d-56a96d7c4037 Content-transfer-encoding: 8BIT Message-id: <56A96D7B.7080505@samsung.com> Date: Thu, 28 Jan 2016 10:23:07 +0900 From: Chanwoo Choi User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Krzysztof Kozlowski , Kukjin Kim , Catalin Marinas , Will Deacon , Michael Turquette , Stephen Boyd , Sylwester Nawrocki , Tomasz Figa , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-clk@vger.kernel.org Cc: Arnd Bergmann , Olof Johansson , Kevin Hilman , Alim Akhtar , Pankaj Dubey Subject: Re: [PATCH v4 2/3] clk: samsung: Don't build ARMv8 clock drivers on ARMv7 References: <1453941324-15742-1-git-send-email-k.kozlowski@samsung.com> <1453941324-15742-3-git-send-email-k.kozlowski@samsung.com> In-reply-to: <1453941324-15742-3-git-send-email-k.kozlowski@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrIIsWRmVeSWpSXmKPExsWyRsSkWLcmd2WYwd+Z2hYP5m1js/g76Ri7 xftlPYwW84+cY7V4/cLQov/xa2aLp5sfM1lsenyN1eJjzz1Wi8u75rBZzDi/j8ni4ilXi1PX P7NZLNr6hd3i8Jt2VosfZ7pZLFbt+sNo8fLjCRYHIY8189Ywevz+NYnR4/2NVnaPy329TB47 Z91l99i0qpPNY/OSeo8rJ5pYPfq2rGL0+LxJLoArissmJTUnsyy1SN8ugSvj/48vjAU3xSpW /lvI2MDYI9zFyMkhIWAi8WPlZyYIW0ziwr31bF2MXBxCAisYJZ7u380EUzTp3xUWiMRSRont F86AJXgFBCV+TL4HlODgYBaQlzhyKRskzCygLjFp3iJmiPoHjBJHXp9khajXknj6bQ8ziM0i oCqx89YrNhCbDSi+/8UNNpA5ogIREt0nKkF6RQQ+MEtM7GxlBXGYBXYySnx5dB5skLBAiMSE t6dZITa0Mkrsm7uEESTBKeAhcfVFD1hCQuAMh8T0mRfYIdYJSHybfAjsVAkBWYlNB5ghXpOU OLjiBssERrFZSB6ahfDQLCQPLWBkXsUomlqQXFCclF5kqFecmFtcmpeul5yfu4kRmBJO/3vW u4Px9gHrQ4wCHIxKPLwMUSvDhFgTy4orcw8xmgIdMZFZSjQ5H5h48kriDY3NjCxMTUyNjcwt zZTEeRWlfgYLCaQnlqRmp6YWpBbFF5XmpBYfYmTi4JRqYKx6v6n3zaLin/8/qandCFJU+xNz WoxbrCHi6M3uvirPqnUX9X04dA6EqKqVNurxf11+jPHfe/Pff3fM+Lcv84mg3kPVjpiLBt9l Izdk3H7xU6wsWtmmjt1N9c1L9UuRMk2cNmLrmdxvRJYwC3yL7ykxd/ZrTSrkzt+5if304gun a+58C8t9ocRSnJFoqMVcVJwIAKeFkL0EAwAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrHKsWRmVeSWpSXmKPExsVy+t9jAd2a3JVhBl3NKhYP5m1js/g76Ri7 xftlPYwW84+cY7V4/cLQov/xa2aLp5sfM1lsenyN1eJjzz1Wi8u75rBZzDi/j8ni4ilXi1PX P7NZLNr6hd3i8Jt2VosfZ7pZLFbt+sNo8fLjCRYHIY8189Ywevz+NYnR4/2NVnaPy329TB47 Z91l99i0qpPNY/OSeo8rJ5pYPfq2rGL0+LxJLoArqoHRJiM1MSW1SCE1Lzk/JTMv3VbJOzje Od7UzMBQ19DSwlxJIS8xN9VWycUnQNctMwfoKSWFssScUqBQQGJxsZK+HaYJoSFuuhYwjRG6 viFBcD1GBmggYQ1jxv8fXxgLbopVrPy3kLGBsUe4i5GTQ0LARGLSvyssELaYxIV769m6GLk4 hASWMkpsv3CGCSTBKyAo8WPyPaAiDg5mAXmJI5eyQcLMAuoSk+YtYoaof8AoceT1SVaIei2J p9/2MIPYLAKqEjtvvWIDsdmA4vtf3GADmSMqECHRfaISpFdE4AOzxMTOVlYQh1lgJ6PEl0fn wQYJC4RITHh7mhViQyujxL65SxhBEpwCHhJXX/SwTmAUmIXkwFkIB85CcuACRuZVjBKpBckF xUnpuUZ5qeV6xYm5xaV56XrJ+bmbGMFp55n0DsbDu9wPMQpwMCrx8DJErQwTYk0sK67MPcQo wcGsJMI7KxkoxJuSWFmVWpQfX1Sak1p8iNEU6MOJzFKiyfnAlJhXEm9obGJmZGlkbmhhZGyu JM6771JkmJBAemJJanZqakFqEUwfEwenVANjl/nFvb9MfD457D+et+WOMbe/IFP7RSd30QMT /loaaHdefDFB9nnS/YTMww9+KsrYSU5tPq2Q7enNIz3ts/Rfr4Cny5TeSz/d89T3AqtmgA5P zeu0C9eNDvBbHs9hY+7wLW96Wd45STSnocd5lumle3wWFz41SM/2eh/3xqMqXyzD0NjxxXEl luKMREMt5qLiRACOG4uTUQMAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2016년 01월 28일 09:35, Krzysztof Kozlowski wrote: > Currently the Exynos5433 (ARMv8 SoC) clock driver depends on ARCH_EXYNOS > so it is built also on ARMv7. This does not bring any kind of benefit. > There won't be a single kernel image for ARMv7 and ARMv8 SoCs (like > multi_v7 for ARMv7). > > Instead build clock drivers only for respective SoC's architecture. > > Signed-off-by: Krzysztof Kozlowski > > --- > > Changes since v3: > 1. Rebase on next-20160127. > > Changes since v2: > 1. Follow Arnd's advice making EXYNOS_ARM64_COMMON_CLK user-visible when > COMPILE_TEST is enabled. > 2. Dropped accumulated tags because the logic is now different. > > Changes since v1: > 1. Use one Kconfig symbol for clocks of all ARM64 SoCs (after > discussion): EXYNOS_ARM64_COMMON_CLK. > 2. Minor cleanups after Tomasz's comments. > 3. Added tags: Chanwoo's, Sylwester's, Alim's and Tomasz's (the tags > were given for v1 but assuming that change from 1. is not major > enough to require re-tagging). > --- > drivers/clk/samsung/Kconfig | 5 +++++ > drivers/clk/samsung/Makefile | 4 ++-- > 2 files changed, 7 insertions(+), 2 deletions(-) > > diff --git a/drivers/clk/samsung/Kconfig b/drivers/clk/samsung/Kconfig > index dd6093a33f84..5fd982d9f4d9 100644 > --- a/drivers/clk/samsung/Kconfig > +++ b/drivers/clk/samsung/Kconfig > @@ -23,3 +23,8 @@ config S3C2443_COMMON_CLK > bool "Samsung S3C2443 clock controller support" if COMPILE_TEST > select COMMON_CLK_SAMSUNG > > +# ARM64 SoCs (e.g. Exynos5433, Exynos7): > +config EXYNOS_ARM64_COMMON_CLK > + bool "Samsung Exynos ARMv8-family clock controller support" if COMPILE_TEST > + default ARM64 && COMMON_CLK_SAMSUNG > + depends on (ARM64 && COMMON_CLK_SAMSUNG) || COMPILE_TEST > diff --git a/drivers/clk/samsung/Makefile b/drivers/clk/samsung/Makefile > index 5f6833ea355d..fc367d4b2902 100644 > --- a/drivers/clk/samsung/Makefile > +++ b/drivers/clk/samsung/Makefile > @@ -10,11 +10,11 @@ obj-$(CONFIG_SOC_EXYNOS5250) += clk-exynos5250.o > obj-$(CONFIG_SOC_EXYNOS5260) += clk-exynos5260.o > obj-$(CONFIG_SOC_EXYNOS5410) += clk-exynos5410.o > obj-$(CONFIG_SOC_EXYNOS5420) += clk-exynos5420.o > -obj-$(CONFIG_ARCH_EXYNOS) += clk-exynos5433.o > +obj-$(CONFIG_EXYNOS_ARM64_COMMON_CLK) += clk-exynos5433.o > obj-$(CONFIG_SOC_EXYNOS5440) += clk-exynos5440.o > obj-$(CONFIG_ARCH_EXYNOS) += clk-exynos-audss.o > obj-$(CONFIG_ARCH_EXYNOS) += clk-exynos-clkout.o > -obj-$(CONFIG_ARCH_EXYNOS7) += clk-exynos7.o > +obj-$(CONFIG_EXYNOS_ARM64_COMMON_CLK) += clk-exynos7.o > obj-$(CONFIG_S3C2410_COMMON_CLK)+= clk-s3c2410.o > obj-$(CONFIG_S3C2410_COMMON_DCLK)+= clk-s3c2410-dclk.o > obj-$(CONFIG_S3C2412_COMMON_CLK)+= clk-s3c2412.o > Looks good to me. Reviewed-by: Chanwoo Choi Best Regards, Chanwoo Choi