From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753877AbcA3CTS (ORCPT <rfc822;w@1wt.eu>);
	Fri, 29 Jan 2016 21:19:18 -0500
Received: from szxga01-in.huawei.com ([58.251.152.64]:42229 "EHLO
	szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753027AbcA3CTQ (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 29 Jan 2016 21:19:16 -0500
Subject: Re: [PATCH v5] mtd: spi-nor: add hisilicon spi-nor flash controller
 driver
To: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>
References: <1454054597-8473-1-git-send-email-xuejiancheng@huawei.com>
 <20160129144502.GA1437@laptop.cereza>
CC: <robh+dt@kernel.org>, <pawel.moll@arm.com>, <mark.rutland@arm.com>,
        <ijc+devicetree@hellion.org.uk>, <galak@codeaurora.org>,
        <dwmw2@infradead.org>, <computersforpeace@gmail.com>,
        <shijie.huang@intel.com>, <pengbinquan@huawei.com>,
        <han.xu@freescale.com>, <fabio.estevam@freescale.com>,
        <manabian@gmail.com>, <devicetree@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <linux-mtd@lists.infradead.org>,
        <yanhaifeng@hisilicon.com>, <yanghongwei@hisilicon.com>,
        <suwenping@hisilicon.com>, <raojun@hisilicon.com>,
        <ml.yang@hisilicon.com>, <gaofei@hisilicon.com>,
        <zhangzhenxing@hisilicon.com>, <xuejiancheng@hisilicon.com>
From: xuejiancheng <xuejiancheng@huawei.com>
Message-ID: <56AC1BF6.8060007@huawei.com>
Date: Sat, 30 Jan 2016 10:12:06 +0800
User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:38.0) Gecko/20100101
 Thunderbird/38.5.0
MIME-Version: 1.0
In-Reply-To: <20160129144502.GA1437@laptop.cereza>
Content-Type: text/plain; charset="windows-1252"
Content-Transfer-Encoding: 7bit
X-Originating-IP: [10.67.217.211]
X-CFilter-Loop: Reflected
X-Mirapoint-Virus-RAPID-Raw: score=unknown(0),
	refid=str=0001.0A020202.56AC1C10.0121,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0,
	ip=0.0.0.0,
	so=2013-06-18 04:22:30,
	dmn=2013-03-21 17:37:32
X-Mirapoint-Loop-Id: b34d8e9c5c60a64932771088dbfd7599
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Ezequiel,

Thank you very much for your comments. I read them carefully.
All of your suggestions are very good and helpful. I will correct
in next version.

Regards,

Jiancheng

.
On 2016/1/29 22:45, Ezequiel Garcia wrote:
> Hi Jiancheng,
>  
> Driver looks mostly good. Few comments below.
> 
> On 29 Jan 04:03 PM, Jiancheng Xue wrote:
>> add hisilicon spi-nor flash controller driver
>>
>