From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757102AbcA3QHF (ORCPT ); Sat, 30 Jan 2016 11:07:05 -0500 Received: from [212.40.180.161] ([212.40.180.161]:53592 "EHLO smtp-out-121.synserver.de" rhost-flags-FAIL-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1757075AbcA3QHE (ORCPT ); Sat, 30 Jan 2016 11:07:04 -0500 X-SynServer-TrustedSrc: 1 X-SynServer-AuthUser: lars@metafoo.de X-SynServer-PPID: 18628 Subject: Re: [PATCH] clk: axi-clkgen: Remove sometimes impossible check To: Stephen Boyd , Mike Turquette References: <1454116408-28866-1-git-send-email-sboyd@codeaurora.org> Cc: linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org From: Lars-Peter Clausen Message-ID: <56ACCFD9.3080300@metafoo.de> Date: Sat, 30 Jan 2016 15:59:37 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Icedove/38.5.0 MIME-Version: 1.0 In-Reply-To: <1454116408-28866-1-git-send-email-sboyd@codeaurora.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/30/2016 02:13 AM, Stephen Boyd wrote: > The size of unsigned long on 64-bit architectures is equal to the > size of u64, so this check is impossible there. This throws off > static checkers: > > drivers/clk/clk-axi-clkgen.c:331 axi_clkgen_recalc_rate() warn: > impossible condition '(tmp > (~0)) => (0-u64max > u64max)' > > Let's change this code to use min_t() instead so that we > get the same effect on architectures where sizeof(unsigned long) > doesn't equal sizeof(u64). > > Cc: Lars-Peter Clausen > Signed-off-by: Stephen Boyd Thanks. Acked-by: Lars-Peter Clausen