mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Stas Sergeev <stsp@list.ru>
To: Linux kernel <linux-kernel@vger.kernel.org>
Cc: Andy Lutomirski <luto@amacapital.net>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
	X86 ML <x86@kernel.org>, Borislav Petkov <bp@suse.de>,
	Brian Gerst <brgerst@gmail.com>, Oleg Nesterov <oleg@redhat.com>,
	Richard Weinberger <richard@nod.at>
Subject: [PATCH 3/4] x86: signal: unify the sigaltstack check with other arches
Date: Sun, 31 Jan 2016 19:24:04 +0300	[thread overview]
Message-ID: <56AE3524.1030403@list.ru> (raw)
In-Reply-To: <56AE3369.2090709@list.ru>


Currently x86's get_sigframe() checks for "current->sas_ss_size"
to determine whether there is a need to switch to sigaltstack.
The common practice used by all other arches is to check for
sas_ss_flags(sp) == 0

This patch makes the code consistent with other arches and also
allows for the further sigaltstack improvements within this patch serie.

CC: Andy Lutomirski <luto@amacapital.net>
CC: linux-kernel@vger.kernel.org
CC: Thomas Gleixner <tglx@linutronix.de>
CC: Ingo Molnar <mingo@redhat.com>
CC: "H. Peter Anvin" <hpa@zytor.com>
CC: x86@kernel.org
CC: Borislav Petkov <bp@suse.de>
CC: Brian Gerst <brgerst@gmail.com>
CC: Oleg Nesterov <oleg@redhat.com>
CC: Richard Weinberger <richard@nod.at>

Signed-off-by: Stas Sergeev <stsp@users.sourceforge.net>
---
  arch/x86/kernel/signal.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/kernel/signal.c b/arch/x86/kernel/signal.c
index cb6282c..3955259 100644
--- a/arch/x86/kernel/signal.c
+++ b/arch/x86/kernel/signal.c
@@ -216,7 +216,7 @@ get_sigframe(struct k_sigaction *ka, struct pt_regs 
*regs, size_t frame_size,
      if (!onsigstack) {
          /* This is the X/Open sanctioned signal stack switching. */
          if (ka->sa.sa_flags & SA_ONSTACK) {
-            if (current->sas_ss_size)
+            if (sas_ss_flags(sp) == 0)
                  sp = current->sas_ss_sp + current->sas_ss_size;
          } else if (config_enabled(CONFIG_X86_32) &&
                 (regs->ss & 0xffff) != __USER_DS &&
-- 
2.5.0

  parent reply	other threads:[~2016-01-31 16:24 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-31 16:16 [PATCH 0/4] make sigaltstack() compatible with swapcontext() Stas Sergeev
2016-01-31 16:18 ` [PATCH 1/4] selftests: Add test for sigaltstack(SS_DISABLE) inside sighandler Stas Sergeev
2016-02-12 16:12   ` Shuah Khan
2016-02-12 16:17     ` Stas Sergeev
2016-01-31 16:21 ` [PATCH 2/4] score: signal: fix sigaltstack check Stas Sergeev
2016-02-02 19:07   ` Lennox Wu
2016-01-31 16:24 ` Stas Sergeev [this message]
2016-01-31 16:58   ` [PATCH 3/4] x86: signal: unify the sigaltstack check with other arches Andy Lutomirski
2016-01-31 18:03     ` Stas Sergeev
2016-01-31 16:28 ` [PATCH 4/4] sigaltstack: allow disabling and re-enabling sas within sighandler Stas Sergeev
2016-01-31 17:00   ` Andy Lutomirski
2016-01-31 17:33     ` Stas Sergeev
2016-01-31 19:03       ` Andy Lutomirski
2016-01-31 20:08         ` Stas Sergeev
2016-01-31 20:11           ` Andy Lutomirski
2016-01-31 22:36             ` Stas Sergeev
2016-01-31 22:44               ` Andy Lutomirski
2016-01-31 23:45                 ` Stas Sergeev
2016-02-01 16:06   ` Oleg Nesterov
2016-02-01 16:57     ` Stas Sergeev
2016-02-01 17:27       ` Oleg Nesterov
2016-02-01 17:09     ` Oleg Nesterov
2016-02-01 17:26       ` Stas Sergeev
2016-02-01 18:04         ` Oleg Nesterov
2016-02-01 18:16           ` Stas Sergeev
2016-02-01 18:28             ` Andy Lutomirski
2016-02-01 18:40               ` Stas Sergeev
2016-02-01 18:52             ` Oleg Nesterov
2016-02-01 19:01               ` Stas Sergeev
2016-02-01 19:29                 ` Oleg Nesterov
2016-02-01 19:46                   ` Stas Sergeev
2016-02-01 20:41                     ` Oleg Nesterov
2016-02-01 23:06                       ` Stas Sergeev
2016-01-31 19:10 [PATCH v2 0/4] make sigaltstack() compatible with swapcontext() Stas Sergeev
2016-01-31 19:16 ` [PATCH 3/4] x86: signal: unify the sigaltstack check with other arches Stas Sergeev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56AE3524.1030403@list.ru \
    --to=stsp@list.ru \
    --cc=bp@suse.de \
    --cc=brgerst@gmail.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@amacapital.net \
    --cc=mingo@redhat.com \
    --cc=oleg@redhat.com \
    --cc=richard@nod.at \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome