From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753417AbcBAKAE (ORCPT <rfc822;w@1wt.eu>);
	Mon, 1 Feb 2016 05:00:04 -0500
Received: from mailout4.w1.samsung.com ([210.118.77.14]:52596 "EHLO
	mailout4.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753174AbcBAJ7q (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 1 Feb 2016 04:59:46 -0500
X-AuditID: cbfec7f5-f79b16d000005389-14-56af2c8f625f
Message-id: <56AF2C8E.7030702@samsung.com>
Date: Mon, 01 Feb 2016 10:59:42 +0100
From: Jacek Anaszewski <j.anaszewski@samsung.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130804
 Thunderbird/17.0.8
MIME-version: 1.0
To: Stefan Wahren <stefan.wahren@i2se.com>
Cc: Richard Purdie <rpurdie@rpsys.net>, Rob Herring <robh+dt@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org
Subject: Re: [PATCH 2/3] DT: add binding for SN3218 LED driver
References: <1454245156-15747-1-git-send-email-stefan.wahren@i2se.com>
 <1454245156-15747-3-git-send-email-stefan.wahren@i2se.com>
In-reply-to: <1454245156-15747-3-git-send-email-stefan.wahren@i2se.com>
Content-type: text/plain; charset=ISO-8859-1; format=flowed
Content-transfer-encoding: 7bit
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrFLMWRmVeSWpSXmKPExsVy+t/xq7r9OuvDDHb1y1vMP3KO1eLyrjls
	FlvfrGO0WHr9IpNF694j7Ba7dz1ltdi04gabA7vHmnlrGD223jL12LSqk81jz/wfrB6fN8kF
	sEZx2aSk5mSWpRbp2yVwZaya3cRa8JK3ovXJf6YGxl9cXYycHBICJhJXv05nh7DFJC7cW88G
	YgsJLGWU2NbF3cXIBWQ/Y5T4+nwHWIJXQEvi84UfLF2MHBwsAqoSlxZGgYTZBAwlfr54zQRi
	iwpESPw5vY8VolxQ4sfkeywgtghQa1fnJrBdzALHGSXefucAsYUF7CT+bLzGDLGrmVHi16Ze
	ZpAEp4C7xIQrt5ggGqwlVk7axghhy0tsXvOWeQKjwCwkO2YhKZuFpGwBI/MqRtHU0uSC4qT0
	XCO94sTc4tK8dL3k/NxNjJAQ/7qDcekxq0OMAhyMSjy8GyLXhQmxJpYVV+YeYpTgYFYS4d37
	FSjEm5JYWZValB9fVJqTWnyIUZqDRUmcd+au9yFCAumJJanZqakFqUUwWSYOTqkGxv4l3tf0
	NxnMNjw5tTLo4uaU/5P9b119s8rgudMTll+yW/YvFfD365Q2c7oVvfFLVEfrvTv8Qfu+3H3n
	4L+2bN+rD3oLr9yYrHz4+yHV0LkGnfOvPNvdrx0nEPyxXTGC+ZTUH50ndh+m3Ol+uTHDve1O
	6d8Kj8C36y5P2O2mEedrfaFbzSdhpaASS3FGoqEWc1FxIgCM/PLbbQIAAA==
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 01/31/2016 01:59 PM, Stefan Wahren wrote:
> This patch adds the binding for Si-En Technology SN3218
> 18-Channel LED driver.
>
> Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
> Acked-by: Rob Herring <robh@kernel.org>
> ---
>   .../devicetree/bindings/leds/leds-sn3218.txt       |   42 ++++++++++++++++++++
>   1 file changed, 42 insertions(+)
>   create mode 100644 Documentation/devicetree/bindings/leds/leds-sn3218.txt
>
> diff --git a/Documentation/devicetree/bindings/leds/leds-sn3218.txt b/Documentation/devicetree/bindings/leds/leds-sn3218.txt
> new file mode 100644
> index 0000000..5daa9b0
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/leds/leds-sn3218.txt
> @@ -0,0 +1,42 @@
> +* Si-En Technology - SN3218 18-Channel LED Driver
> +
> +Required properties:
> +- compatible :
> +	"si-en,sn3218"
> +- address-cells : must be 1
> +- size-cells : must be 0
> +- reg : I2C slave address, typically 0x54
> +
> +There must be at least 1 LED which is represented as a sub-node
> +of the sn3218 device.
> +
> +LED sub-node properties:
> +- label : (optional) see Documentation/devicetree/bindings/leds/common.txt
> +- reg : number of LED line (could be from 0 to 17)
> +- linux,default-trigger : (optional)
> +   see Documentation/devicetree/bindings/leds/common.txt
> +
> +Example:
> +
> +sn3218: led-controller@54 {
> +	compatible = "si-en,sn3218";
> +	#address-cells = <1>;
> +	#size-cells = <0>;
> +	reg = <0x54>;
> +
> +	led@0 {
> +		label = "led1";
> +		reg = <0x0>;
> +	};
> +
> +	led@1 {
> +		label = "led2";
> +		reg = <0x1>;
> +	};
> +
> +	led@2 {
> +		label = "led3";
> +		reg = <0x2>;
> +	};
> +};
> +

Please remove this empty line.

-- 
Best Regards,
Jacek Anaszewski