From: "Maciej S. Szmigiero" <mail@maciej.szmigiero.name>
To: Fabio Estevam <festevam@gmail.com>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
Timur Tabi <timur@tabi.org>,
Nicolin Chen <nicoleotsuka@gmail.com>,
Xiubo Li <Xiubo.Lee@gmail.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ASoC: fsl_ssi: remove explicit register defaults
Date: Mon, 01 Feb 2016 13:07:59 +0100 [thread overview]
Message-ID: <56AF4A9F.4060401@maciej.szmigiero.name> (raw)
In-Reply-To: <CAOMZO5DwQza+jDdkA80v4wkrB56y53tOjkP2-36YNq2WBLodaA@mail.gmail.com>
Hi Fabio,
On 01.02.2016 13:05, Fabio Estevam wrote:
> Hi Maciej,
>
> On Mon, Jan 18, 2016 at 5:07 PM, Maciej S. Szmigiero
> <mail@maciej.szmigiero.name> wrote:
>> There is no guarantee that on fsl_ssi module load
>> SSI registers will have their power-on-reset values.
>>
>> In fact, if the driver is reloaded the values in
>> registers will be whatever they were set to previously.
>>
>> However, the cache needs to be fully populated at probe
>> time to avoid non-atomic allocations during register
>> access.
>>
>> Special case here is imx21-class SSI, since
>> according to datasheet it don't have SACC{ST,EN,DIS}
>> regs.
>>
>> This fixes hard lockup on fsl_ssi module reload,
>> at least in AC'97 mode.
>>
>> Fixes: 05cf237972fe ("ASoC: fsl_ssi: Add driver suspend and resume to support MEGA Fast")
>>
>> Signed-off-by: Maciej S. Szmigiero <mail@maciej.szmigiero.name>
>
> I know I have already tested this and it worked fine on a mx6sabresd,
> but running linux-next 20160201 on a mx6sl-evk the ssi driver does not
> probe anymore:
>
> [ 2.216954] fsl-asoc-card sound: ASoC: CPU DAI (null) not registered
> [ 2.223412] fsl-asoc-card sound: snd_soc_register_card failed (-517)
> [ 2.230258] imx-wm8962 sound: ASoC: CPU DAI 202c000.ssi not registered
> [ 2.236806] imx-wm8962 sound: snd_soc_register_card failed (-517)
> [ 2.244782] snvs_rtc 20cc000.snvs:snvs-rtc-lp: setting system clock
> to 1970-01-01 00:01:14 UTC (74)
> [ 2.285864] fsl-asoc-card sound: ASoC: CPU DAI (null) not registered
> [ 2.292335] fsl-asoc-card sound: snd_soc_register_card failed (-517)
> [ 2.299572] imx-wm8962 sound: ASoC: CPU DAI 202c000.ssi not registered
> [ 2.306121] imx-wm8962 sound: snd_soc_register_card failed (-517)
>
> Reverting this patch fixes the problem.
>
> Wandboard also has the same issue:
>
> http://arm-soc.lixom.net/bootlogs/next/next-20160201/wandboard-arm-imx_v6_v7_defconfig.html
>
> Any suggestions?
>
> Thanks
>
Is regmap patch from
http://www.spinics.net/lists/kernel/msg2161934.html
applied to the tested tree?
Best regards,
Maciej
next prev parent reply other threads:[~2016-02-01 12:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-18 19:07 Maciej S. Szmigiero
2016-01-18 22:14 ` Fabio Estevam
2016-02-01 12:05 ` Fabio Estevam
2016-02-01 12:07 ` Maciej S. Szmigiero [this message]
2016-02-01 12:13 ` Fabio Estevam
2016-02-01 12:25 ` Maciej S. Szmigiero
2016-02-01 16:58 ` Maciej S. Szmigiero
2016-02-01 21:10 ` Mark Brown
2016-02-01 21:30 ` Maciej S. Szmigiero
2016-02-01 21:34 ` Fabio Estevam
2016-02-01 21:37 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56AF4A9F.4060401@maciej.szmigiero.name \
--to=mail@maciej.szmigiero.name \
--cc=Xiubo.Lee@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=festevam@gmail.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=nicoleotsuka@gmail.com \
--cc=timur@tabi.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®