From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932401AbcBANUj (ORCPT ); Mon, 1 Feb 2016 08:20:39 -0500 Received: from mout.kundenserver.de ([212.227.126.133]:49711 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932269AbcBANUg (ORCPT ); Mon, 1 Feb 2016 08:20:36 -0500 Subject: Re: [PATCH 3/3] leds: add SN3218 LED driver To: Jacek Anaszewski References: <1454245156-15747-1-git-send-email-stefan.wahren@i2se.com> <1454245156-15747-4-git-send-email-stefan.wahren@i2se.com> <56AF2C63.6000404@samsung.com> <56AF5567.4090102@samsung.com> Cc: Richard Purdie , Rob Herring , Mark Rutland , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org From: Stefan Wahren Message-ID: <56AF5B91.1000209@i2se.com> Date: Mon, 1 Feb 2016 14:20:17 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <56AF5567.4090102@samsung.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:hZcGgugLHsnipHz9Zn3zed0sNqEYBH7dNTY4NAZR7xxz2wLgRjo v53Gfq1f/KO/zr20Vz9OjxjI9pOpLAuYExU1CJ/xPBYy0ffBz4diB260MvYXOz6a3v8T2DF ISj/g1GAXWAQINAodyJkv9t9FVQdboPyx8g91EZvK4MUdMmuYDRFy+g71zMa4mECujHtLRI 4HftWnPf7DbsxsJ6J1xgA== X-UI-Out-Filterresults: notjunk:1;V01:K0:H8DlKgebaKM=:uYXFYYs4sZZDjV/9W0hhXe i6fZe3NC/eov4b4vVUpQ5iXfBIpcX3ymHTeIlYQZ2//l4fQK3/VGR/q48+RuZOJNllCe9XTVw wleKUKBt8uxrh7IOoxvFsvhDI+Ybl+E8dmPKOWIjh0+VYDMFaDQFgZAB6sIKyX3z2kG392eel xUwpsql5LeKlaenXRRsqW7M3CpEU9g77ZTs2djVpsmTNR+aEE6W5xZEGHcplL1nkIYFg65u3f f8q3bM93n621Aqux/Jz6FGE+UdWpP288KUkVdC7+OKW1F89HJp9RF4IjQAaTnTILp6gwOboqs HaZ584OCAj2l1UPjFRShuBUZbauHyORL2jewv0cQhUHrcROgVU4JaPy2keXHfaj1ZUbQuBgxh TQmwE5aZPKZKoTv1RRa1zQIAkSp2i68MS0hgty+C15u1CQGkZsZEOteRb8iNbn/echL0uvTwb KTJ274d9GKGDTqrNqm7XILz1FcsBw0ooTe9D5MiK+6PMavXn1TnlSSYYEMzpJkZNXiCDrP+KB SPJXh06hBgx/pUGVdjRqIlGT6nTb2BPHHXOpfPRuSK2Y6HkBqGPHtCnlRz7nw28Fs5dnLY7tX cVVv76EdY83FMeUAUCNgDKZ8c4l3f5GrDqLcicFwX5vd0cZ8nHx5PAM1gzrP4esbQC0pL/JbW qB4ZFnoJJeK17U9dDd/0xJG1ojDt1mH1QXI/X9DuPhWMIKtLWTpoyy5d91BynxplWa2taCZho hxQ8vecEXnmUXxKo Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 01.02.2016 um 13:53 schrieb Jacek Anaszewski: > On 02/01/2016 10:58 AM, Jacek Anaszewski wrote: >> Hi Stefan, >> >> Thanks for the update. A few more comments below. >> >> On 01/31/2016 01:59 PM, Stefan Wahren wrote: >>> + >>> +/** >>> + * struct sn3218 - >>> + * @client - Pointer to the I2C client >>> + * @leds - Pointer to the individual LEDs >>> + * @num_leds - Actual number of LEDs >>> +**/ >>> +struct sn3218 { >>> + struct i2c_client *client; >>> + struct regmap *regmap; >>> + struct sn3218_led *leds; >>> + int num_leds; >>> +}; >>> + >>> +/** >>> + * struct sn3218_led - >>> + * @chip - Pointer to the container >>> + * @led_cdev - led class device pointer >>> + * @led_num - LED index ( 0 .. 17 ) >>> +**/ >>> +struct sn3218_led { >>> + struct sn3218 *chip; >> >> You don't need this if you have led id here. Please refer to >> drivers/leds/leds-max77693.c, sub_led_to_led() to check how to get >> a pointer to the parent structure in similar case. > > Hmm, it would work only if leds was a static array in struct sn3218. > So, let's better leave this "chip" pointer intact. Okay I will wait until the end of the week before sending a new version. Thanks Stefan