From: Rik van Riel <riel@redhat.com>
To: Peter Zijlstra <peterz@infradead.org>,
Thomas Gleixner <tglx@linutronix.de>
Cc: linux-kernel@vger.kernel.org, fweisbec@gmail.com,
mingo@kernel.org, luto@amacapital.net, clark@redhat.com
Subject: Re: [PATCH 1/4] sched,time: remove non-power-of-two divides from __acct_update_integrals
Date: Mon, 1 Feb 2016 08:44:44 -0500 [thread overview]
Message-ID: <56AF614C.4070702@redhat.com> (raw)
In-Reply-To: <20160201092223.GL6357@twins.programming.kicks-ass.net>
On 02/01/2016 04:22 AM, Peter Zijlstra wrote:
> On Mon, Feb 01, 2016 at 09:37:00AM +0100, Thomas Gleixner wrote:
>> On Sun, 31 Jan 2016, riel@redhat.com wrote:
>>> @@ -93,9 +93,9 @@ void xacct_add_tsk(struct taskstats *stats, struct task_struct *p)
>>> {
>>> struct mm_struct *mm;
>>>
>>> - /* convert pages-usec to Mbyte-usec */
>>> - stats->coremem = p->acct_rss_mem1 * PAGE_SIZE / MB;
>>> - stats->virtmem = p->acct_vm_mem1 * PAGE_SIZE / MB;
>>> + /* convert pages-nsec/1024 to Mbyte-usec, see __acct_update_integrals */
>>> + stats->coremem = p->acct_rss_mem1 * PAGE_SIZE / (1000 * KB);
>>> + stats->virtmem = p->acct_vm_mem1 * PAGE_SIZE / (1000 * KB);
>>
>> You replace "/ (1024 * 1024)" by "/ (1000 * 1024). So that's introducing a non
>> power of 2 division instead of removing one and wont compile on systems which
>> do not have a 64/32 division in hardware.
>
> Yep, so that needs to be fixed to use do_div(). But the reason for this
> is that this is the consumer side of these stats and therefore rarely
> executed.
Before I send in a v4 with do_div in that location, are there
any other changes you would like me to make to the code?
--
All rights reversed
next prev parent reply other threads:[~2016-02-01 13:44 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-01 2:12 [PATCH 0/4 v3] sched,time: reduce nohz_full syscall overhead 40% riel
2016-02-01 2:12 ` [PATCH 1/4] sched,time: remove non-power-of-two divides from __acct_update_integrals riel
2016-02-01 4:46 ` kbuild test robot
2016-02-01 8:37 ` Thomas Gleixner
2016-02-01 9:22 ` Peter Zijlstra
2016-02-01 9:31 ` Thomas Gleixner
2016-02-01 13:44 ` Rik van Riel [this message]
2016-02-01 13:51 ` Peter Zijlstra
2016-02-01 2:12 ` [PATCH 2/4] acct,time: change indentation in __acct_update_integrals riel
2016-02-01 2:12 ` [PATCH 3/4] time,acct: drop irq save & restore from __acct_update_integrals riel
2016-02-01 9:28 ` Peter Zijlstra
2016-02-01 19:22 ` Rik van Riel
2016-02-01 2:12 ` [PATCH 4/4] sched,time: only call account_{user,sys,guest,idle}_time once a jiffy riel
2016-02-01 9:29 ` Peter Zijlstra
2016-02-01 19:23 ` Rik van Riel
2016-02-01 7:41 ` [PATCH] perf tooling: Add 'perf bench syscall' benchmark Ingo Molnar
2016-02-01 7:48 ` [PATCH] perf tooling: Simplify 'perf bench syscall' Ingo Molnar
2016-02-01 15:41 ` [PATCH] perf tooling: Add 'perf bench syscall' benchmark Andy Lutomirski
2016-02-03 10:22 ` Ingo Molnar
2016-06-20 18:00 ` [PATCH] perf: add 'perf bench syscall' Josh Poimboeuf
2016-06-20 19:16 ` Andy Lutomirski
2016-06-21 14:55 ` Josh Poimboeuf
2016-06-21 16:31 ` Andy Lutomirski
-- strict thread matches above, loose matches on Subject: below --
2016-02-11 1:08 [PATCH 0/4 v6] sched,time: reduce nohz_full syscall overhead 40% riel
2016-02-11 1:08 ` [PATCH 1/4] sched,time: remove non-power-of-two divides from __acct_update_integrals riel
2016-02-02 17:19 [PATCH 0/4 v5] sched,time: reduce nohz_full syscall overhead 40% riel
2016-02-02 17:19 ` [PATCH 1/4] sched,time: remove non-power-of-two divides from __acct_update_integrals riel
2016-02-01 19:21 [PATCH 0/4 v4] sched,time: reduce nohz_full syscall overhead 40% riel
2016-02-01 19:21 ` [PATCH 1/4] sched,time: remove non-power-of-two divides from __acct_update_integrals riel
2016-01-30 3:36 [PATCH 0/2] sched,time: reduce nohz_full syscall overhead 40% riel
2016-01-30 3:36 ` [PATCH 1/4] sched,time: remove non-power-of-two divides from __acct_update_integrals riel
2016-01-30 4:56 ` kbuild test robot
2016-01-30 14:44 ` Frederic Weisbecker
2016-01-30 17:53 ` Rik van Riel
2016-02-01 11:30 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56AF614C.4070702@redhat.com \
--to=riel@redhat.com \
--cc=clark@redhat.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome