From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752725AbcBAStj (ORCPT ); Mon, 1 Feb 2016 13:49:39 -0500 Received: from mail-wm0-f43.google.com ([74.125.82.43]:37586 "EHLO mail-wm0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752061AbcBASth (ORCPT ); Mon, 1 Feb 2016 13:49:37 -0500 Subject: Re: [PATCH] lightnvm: put bio before return To: Wenwei Tao References: <1453975694-18305-1-git-send-email-ww.tao0320@gmail.com> Cc: linux-kernel@vger.kernel.org, linux-block@vger.kernel.org From: =?UTF-8?Q?Matias_Bj=c3=b8rling?= Message-ID: <56AFA8BE.5090505@lightnvm.io> Date: Mon, 1 Feb 2016 19:49:34 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <1453975694-18305-1-git-send-email-ww.tao0320@gmail.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/28/2016 11:08 AM, Wenwei Tao wrote: > Signed-off-by: Wenwei Tao > --- > drivers/lightnvm/rrpc.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/lightnvm/rrpc.c b/drivers/lightnvm/rrpc.c > index d8c7595..307db1e 100644 > --- a/drivers/lightnvm/rrpc.c > +++ b/drivers/lightnvm/rrpc.c > @@ -300,8 +300,10 @@ static int rrpc_move_valid_pages(struct rrpc *rrpc, struct rrpc_block *rblk) > } > > page = mempool_alloc(rrpc->page_pool, GFP_NOIO); > - if (!page) > + if (!page) { > + bio_put(bio); > return -ENOMEM; > + } > > while ((slot = find_first_zero_bit(rblk->invalid_pages, > nr_pgs_per_blk)) < nr_pgs_per_blk) { > Thanks Wenwei. Applied for next -rc. I've updated the commit text a bit.