From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754012AbcBBIqU (ORCPT ); Tue, 2 Feb 2016 03:46:20 -0500 Received: from prv-mh.provo.novell.com ([137.65.248.74]:51606 "EHLO prv-mh.provo.novell.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751637AbcBBIqT convert rfc822-to-8bit (ORCPT ); Tue, 2 Feb 2016 03:46:19 -0500 Message-Id: <56B07AE902000078000CD54A@prv-mh.provo.novell.com> X-Mailer: Novell GroupWise Internet Agent 14.2.0 Date: Tue, 02 Feb 2016 01:46:17 -0700 From: "Jan Beulich" To: "Ingo Molnar" Cc: "Peter Zijlstra" , , "Thomas Gleixner" , , Subject: Re: [PATCH v2] x86/mm: avoid premature success when changing page attributes References: <56A6615E02000078000CAC96@prv-mh.provo.novell.com> <56A8AD9E02000078000CB7CA@prv-mh.provo.novell.com> <56A8B64A02000078000CB830@prv-mh.provo.novell.com> <20160128084232.GA24464@gmail.com> In-Reply-To: <20160128084232.GA24464@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 8BIT Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >>> On 28.01.16 at 09:42, wrote: > Could we try a v3? Okay, I withdraw the patch: Upon further consideration it is note really clear what the intended behavior of set_memory_*() on address ranges with mapping holes is supposed to be. The original issue was with set_memory_nx() (called from mark_rodata_ro()) stumbling across an unmapped region (resulting from an out of tree change completely unmapping the kernel mappings of address ranges passed to free_init_pages()). I simply don't have the time to check whether the unmapping done with CONFIG_DEBUG_PAGEALLOC would have a similar effect. The net result in any event were pages (past the hole) reported as problematic when CONFIG_DEBUG_WX is enabled. Jan