From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756797AbcBCIs0 (ORCPT ); Wed, 3 Feb 2016 03:48:26 -0500 Received: from mail-wm0-f51.google.com ([74.125.82.51]:37357 "EHLO mail-wm0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752968AbcBCIsY (ORCPT ); Wed, 3 Feb 2016 03:48:24 -0500 Subject: Re: [alsa-devel] [PATCH RFC 00/15] ASoC: qcom: Add capture support. To: Patrick Lai , alsa-devel@alsa-project.org, Banajit Goswami , Liam Girdwood , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Takashi Iwai , Mark Brown References: <1454347622-9970-1-git-send-email-srinivas.kandagatla@linaro.org> <20160203003310.GA14436@kwestfie-linux.qualcomm.com> From: Srinivas Kandagatla Message-ID: <56B1BED5.2090708@linaro.org> Date: Wed, 3 Feb 2016 08:48:21 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <20160203003310.GA14436@kwestfie-linux.qualcomm.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Thanks Kenneth for review comments. On 03/02/16 00:33, Kenneth Westfield wrote: > On Mon, Feb 01, 2016 at 09:27:02AM -0800, Srinivas Kandagatla wrote: >> LPASS IP on QCOM SOC supports both Playback and capture >> via I2S, but this feature is missing in existing code. >> This patchset aims at adding capture support to lpass IP. >> First few patches in this series does cleanup the driver >> to make easy to add capture support. >> >> These patches are tested on DB410C with Headset Mic. > > Thanks for posting this. I went through the changes, and it mostly > looks good minus some small, easy-to-fix nits. I agree with all the comments, and will send a new version with fixes. --srini >