From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964830AbcBCIsm (ORCPT ); Wed, 3 Feb 2016 03:48:42 -0500 Received: from mail-wm0-f51.google.com ([74.125.82.51]:35973 "EHLO mail-wm0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756810AbcBCIsi (ORCPT ); Wed, 3 Feb 2016 03:48:38 -0500 Subject: Re: [alsa-devel] [PATCH RFC 05/15] ASoC: qcom: ipq806x: add error in dma allocation. To: Patrick Lai , alsa-devel@alsa-project.org, Banajit Goswami , Liam Girdwood , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Takashi Iwai , Mark Brown References: <1454347622-9970-1-git-send-email-srinivas.kandagatla@linaro.org> <1454347723-10550-1-git-send-email-srinivas.kandagatla@linaro.org> <20160203003622.GF14436@kwestfie-linux.qualcomm.com> From: Srinivas Kandagatla Message-ID: <56B1BEE4.9090406@linaro.org> Date: Wed, 3 Feb 2016 08:48:36 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <20160203003622.GF14436@kwestfie-linux.qualcomm.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/02/16 00:36, Kenneth Westfield wrote: > On Mon, Feb 01, 2016 at 09:28:43AM -0800, Srinivas Kandagatla wrote: >> diff --git a/sound/soc/qcom/lpass-ipq806x.c >> b/sound/soc/qcom/lpass-ipq806x.c >> index 119048c..8bdcdcb 100644 >> --- a/sound/soc/qcom/lpass-ipq806x.c >> +++ b/sound/soc/qcom/lpass-ipq806x.c >> @@ -65,7 +65,10 @@ static struct snd_soc_dai_driver >> ipq806x_lpass_cpu_dai_driver = { >> >> static int ipq806x_lpass_alloc_dma_channel(struct lpass_data *drvdata, >> int dir) >> { >> - return IPQ806X_LPAIF_RDMA_CHAN_MI2S; >> + if (dir == SNDRV_PCM_STREAM_PLAYBACK) >> + return IPQ806X_LPAIF_RDMA_CHAN_MI2S; >> + else /* Capture not supported */ >> + return -EINVAL; >> } > > The comment could be read as "Capture not supported by hardware", which > isn't true. Maybe "Capture currently not implemented"? Agreed, I will change this in next version. >