From: "Matias Bjørling" <mb@lightnvm.io>
To: "Javier González" <jg@lightnvm.io>
Cc: linux-kernel@vger.kernel.org, linux-block@vger.kernel.org,
"Javier González" <javier@cnexlabs.com>
Subject: Re: [PATCH 2/2] lightnvm: fix request intersection locking in rrpc
Date: Wed, 3 Feb 2016 09:53:51 +0100 [thread overview]
Message-ID: <56B1C01F.9000001@lightnvm.io> (raw)
In-Reply-To: <1454322873-28687-2-git-send-email-javier@javigon.com>
On 02/01/2016 11:34 AM, Javier González wrote:
> This patch fixes an error on the calculation of intersecting logical
> addresses; it contemplates the case where a new request including
> several addresses intersects with a single locked address. This case is
> typical when multiple pages are sent in a new request, while GC - which
> at the moment sends one address at the time - is running.
>
> Signed-off-by: Javier González <javier@cnexlabs.com>
> ---
> drivers/lightnvm/rrpc.h | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/lightnvm/rrpc.h b/drivers/lightnvm/rrpc.h
> index c27283a..3989d65 100644
> --- a/drivers/lightnvm/rrpc.h
> +++ b/drivers/lightnvm/rrpc.h
> @@ -174,8 +174,7 @@ static inline sector_t rrpc_get_sector(sector_t laddr)
> static inline int request_intersects(struct rrpc_inflight_rq *r,
> sector_t laddr_start, sector_t laddr_end)
> {
> - return (laddr_end >= r->l_start && laddr_end <= r->l_end) &&
> - (laddr_start >= r->l_start && laddr_start <= r->l_end);
> + return (laddr_end >= r->l_start) && (laddr_start <= r->l_end);
> }
>
> static int __rrpc_lock_laddr(struct rrpc *rrpc, sector_t laddr,
>
Thanks, applied for next -rc.
next prev parent reply other threads:[~2016-02-03 8:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-01 10:34 [PATCH 1/2] lightnvm: warn if irqs are disabled in lock laddr Javier González
2016-02-01 10:34 ` [PATCH 2/2] lightnvm: fix request intersection locking in rrpc Javier González
2016-02-03 8:53 ` Matias Bjørling [this message]
2016-02-03 8:54 ` [PATCH 1/2] lightnvm: warn if irqs are disabled in lock laddr Matias Bjørling
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56B1C01F.9000001@lightnvm.io \
--to=mb@lightnvm.io \
--cc=javier@cnexlabs.com \
--cc=jg@lightnvm.io \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome