From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757684AbcBDGPH (ORCPT ); Thu, 4 Feb 2016 01:15:07 -0500 Received: from mailout2.samsung.com ([203.254.224.25]:33466 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755722AbcBDGPE (ORCPT ); Thu, 4 Feb 2016 01:15:04 -0500 X-AuditID: cbfee68e-f793c6d00000136c-66-56b2ec67b501 Message-id: <56B2EC67.4010909@samsung.com> Date: Thu, 04 Feb 2016 15:15:03 +0900 From: Jaehoon Chung User-Agent: Mozilla/5.0 (X11; Linux i686; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-version: 1.0 To: Shawn Lin , Ulf Hansson Cc: linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mmc: dw_mmc-rockchip: remove dw_mci_rockchip_pmops References: <1454470004-21408-1-git-send-email-shawn.lin@rock-chips.com> In-reply-to: <1454470004-21408-1-git-send-email-shawn.lin@rock-chips.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpnkeLIzCtJLcpLzFFi42JZI2JSoJv+ZlOYwduDQhaXd81hszjyv5/R 4s6T9awWx9eGO7B43Lm2h83j76z9LB6fN8kFMEdx2aSk5mSWpRbp2yVwZUw7PJu14BJvxc31 qxgbGNu5uxg5OSQETCQe/vzKDGGLSVy4t56ti5GLQ0hgBaPEowl32GCK7szZzAyRmMUocWnZ biaQhJDAA0aJh99zQWxeAS2JHcfegDWwCKhKHDs4GayGTUBHYvu342C2qECYxIN1e1kh6gUl fky+xwJiiwj4SWzdsRWsl1nAWuLnj1awGmEBd4nPRyazQOzykFj4dwXYpZwCnhIHJp8AmskB VK8ncf+iFkSrvMTmNW/B7pQQWMUusff4X3aIewQkvk0+xAJSLyEgK7HpANTDkhIHV9xgmcAo NgvJRbMQps5CMnUBI/MqRtHUguSC4qT0IiO94sTc4tK8dL3k/NxNjMD4Of3vWd8OxpsHrA8x CnAwKvHwNnhuChNiTSwrrsw9xGgKdMREZinR5HxglOaVxBsamxlZmJqYGhuZW5opifMmSP0M FhJITyxJzU5NLUgtii8qzUktPsTIxMEp1cC4YsaJzQlMu1eHFQetWX1TX7pdwku0yvplQl9E 1eS6M1vSjaq+b1r74Ybb/C1HdHdFfbUtWTrdOyuHJXhGtlW90+UndQt+NO4JaAqJWXCkfZ5K 3fEX0v/WGdxKXli0yvi7yzbe8DlW05QPTswSTRYTWfXWZebp5bev7vB7tXl+xFRRjpDNirOb lViKMxINtZiLihMB67ay4poCAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrCIsWRmVeSWpSXmKPExsVy+t9jQd30N5vCDJ6d4rW4vGsOm8WR//2M FneerGe1OL423IHF4861PWwef2ftZ/H4vEkugDmqgdEmIzUxJbVIITUvOT8lMy/dVsk7ON45 3tTMwFDX0NLCXEkhLzE31VbJxSdA1y0zB2ibkkJZYk4pUCggsbhYSd8O04TQEDddC5jGCF3f kCC4HiMDNJCwhjFj2uHZrAWXeCturl/F2MDYzt3FyMkhIWAicWfOZmYIW0ziwr31bF2MXBxC ArMYJS4t280EkhASeMAo8fB7LojNK6AlsePYGzYQm0VAVeLYwclgNWwCOhLbvx0Hs0UFwiQe rNvLClEvKPFj8j0WEFtEwE9i646tYL3MAtYSP3+0gtUIC7hLfD4ymQVil4fEwr8rwA7iFPCU ODD5BNBMDqB6PYn7F7UgWuUlNq95yzyBEehIhA2zEKpmIalawMi8ilEitSC5oDgpPdcwL7Vc rzgxt7g0L10vOT93EyM4Rp9J7WA8uMv9EKMAB6MSD+8N701hQqyJZcWVuYcYJTiYlUR4vV4C hXhTEiurUovy44tKc1KLDzGaAoNgIrOUaHI+MH3klcQbGpuYGVkamRtaGBmbK4nzPv6/LkxI ID2xJDU7NbUgtQimj4mDU6qBsWO/yId9Uk//TjR/x3X16Ra+t8UG6cmRX/KfVx5qWfhLr5dN U5zN77G7vs6Sj+czeN8+S9z83ee+BNODhqJ7F16lmMilsbq4hOX8Z4+cLLZwu94/u7ni1Vtq Vb2PxV/a+vjRb/3P/xk5PzAuPB3mfuDFlaMCFTvuph5rlFh/lalOcYeRyhFDRyWW4oxEQy3m ouJEAHxTwTXnAgAA DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Shawn. On 02/03/2016 12:26 PM, Shawn Lin wrote: > dw_mci_rockchip_pmops just copy-paste what dw_mci_pltfm_pmops > have done. Let's remove it. Yep, it's possible to remove. I'm not sure but i want to know there is no plan to add the specific code of rockchip in suspend/resume. Could you check this? Best Regards, Jaehoon Chung > > Signed-off-by: Shawn Lin > --- > > drivers/mmc/host/dw_mmc-rockchip.c | 22 +--------------------- > 1 file changed, 1 insertion(+), 21 deletions(-) > > diff --git a/drivers/mmc/host/dw_mmc-rockchip.c b/drivers/mmc/host/dw_mmc-rockchip.c > index d9c92f3..3438ab3 100644 > --- a/drivers/mmc/host/dw_mmc-rockchip.c > +++ b/drivers/mmc/host/dw_mmc-rockchip.c > @@ -276,33 +276,13 @@ static int dw_mci_rockchip_probe(struct platform_device *pdev) > return dw_mci_pltfm_register(pdev, drv_data); > } > > -#ifdef CONFIG_PM_SLEEP > -static int dw_mci_rockchip_suspend(struct device *dev) > -{ > - struct dw_mci *host = dev_get_drvdata(dev); > - > - return dw_mci_suspend(host); > -} > - > -static int dw_mci_rockchip_resume(struct device *dev) > -{ > - struct dw_mci *host = dev_get_drvdata(dev); > - > - return dw_mci_resume(host); > -} > -#endif /* CONFIG_PM_SLEEP */ > - > -static SIMPLE_DEV_PM_OPS(dw_mci_rockchip_pmops, > - dw_mci_rockchip_suspend, > - dw_mci_rockchip_resume); > - > static struct platform_driver dw_mci_rockchip_pltfm_driver = { > .probe = dw_mci_rockchip_probe, > .remove = dw_mci_pltfm_remove, > .driver = { > .name = "dwmmc_rockchip", > .of_match_table = dw_mci_rockchip_match, > - .pm = &dw_mci_rockchip_pmops, > + .pm = &dw_mci_pltfm_pmops, > }, > }; > >