From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1756745AbcBDKYb (ORCPT <rfc822;w@1wt.eu>);
	Thu, 4 Feb 2016 05:24:31 -0500
Received: from hqemgate15.nvidia.com ([216.228.121.64]:17007 "EHLO
	hqemgate15.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1754033AbcBDKY0 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 4 Feb 2016 05:24:26 -0500
X-PGP-Universal: processed;
	by hqnvupgp07.nvidia.com on Thu, 04 Feb 2016 02:24:20 -0800
Message-ID: <56B3242E.1060504@nvidia.com>
Date: Thu, 4 Feb 2016 15:43:02 +0530
From: Laxman Dewangan <ldewangan@nvidia.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0
MIME-Version: 1.0
To: Krzysztof Kozlowski <k.kozlowski@samsung.com>, <lee.jones@linaro.org>,
        <alexandre.belloni@free-electrons.com>, <javier@osg.samsung.com>
CC: <cw00.choi@samsung.com>, <linux-kernel@vger.kernel.org>,
        <rtc-linux@googlegroups.com>
Subject: Re: [PATCH V3 5/5] rtc: max77686: move initialisation of rtc regmap,
 irq chip locally
References: <1454507233-9959-1-git-send-email-ldewangan@nvidia.com> <1454507233-9959-6-git-send-email-ldewangan@nvidia.com> <56B296F6.3060002@samsung.com> <56B2B17A.1000509@nvidia.com> <56B2F6A2.5060103@samsung.com> <56B314F4.6010605@samsung.com>
In-Reply-To: <56B314F4.6010605@samsung.com>
X-Originating-IP: [10.19.65.30]
X-ClientProxiedBy: DRUKMAIL101.nvidia.com (10.25.59.19) To
 bgmail102.nvidia.com (10.25.59.11)
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On Thursday 04 February 2016 02:38 PM, Krzysztof Kozlowski wrote:
> On 04.02.2016 15:58, Krzysztof Kozlowski wrote:
>> On 04.02.2016 11:03, Laxman Dewangan wrote:
>>> 3. Can you try locally to not use devm_regmap_init_i2c() and just use
>>> the regmap_init_i2c() and proper removal of this from error path and
>>> remove callback?
>> I'll try to find some time for that. Maybe tomorrow.
> regmap_init_i2c does not help. However helps commenting out the:
> 	regmap_del_irq_chip(info->rtc_irq, info->rtc_irq_data);
> from remove() callback.
>
>

Thanks for debugging.  I do not see anything on regmap_del_irq_chip() 
which can be suspected. Is this because of sharing interrupt between mfd 
and rtc driver?

What is your suggestion here?  Should we avoid this inside RTC driver 
(creating this in mfd) and pass this information to the rtc driver using 
customized platform driver?