From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965896AbcBEASc (ORCPT ); Thu, 4 Feb 2016 19:18:32 -0500 Received: from mailout2.w1.samsung.com ([210.118.77.12]:19127 "EHLO mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933526AbcBEAS3 (ORCPT ); Thu, 4 Feb 2016 19:18:29 -0500 X-AuditID: cbfec7f5-f79b16d000005389-4c-56b3ea520112 Subject: Re: [rtc-linux] Re: [PATCH v4 00/10] rtc: max77686: Extend driver and add max77802 support To: Alexandre Belloni References: <1453865806-4661-1-git-send-email-javier@osg.samsung.com> <20160131120525.GM20165@piout.net> <56ADF9D4.2050208@samsung.com> <20160204225655.GE4782@piout.net> Cc: rtc-linux@googlegroups.com, Javier Martinez Canillas , k.kozlowski.k@gmail.com, linux-kernel@vger.kernel.org, Kukjin Kim , Andi Shyti , Chanwoo Choi , Laxman Dewangan , linux-samsung-soc@vger.kernel.org, Arnd Bergmann , Olof Johansson , linux-arm-kernel@lists.infradead.org From: Krzysztof Kozlowski X-Enigmail-Draft-Status: N1110 Message-id: <56B3EA4D.4010801@samsung.com> Date: Fri, 05 Feb 2016 09:18:21 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-version: 1.0 In-reply-to: <20160204225655.GE4782@piout.net> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrKIsWRmVeSWpSXmKPExsVy+t/xK7pBrzaHGfx9w2HRcW0xk8X2I89Y Lf5OOsZucf3Lc1aLN2/XMFk8//eD3eL1C0OL/sevmS2W7lvNYrHp8TVWi8u75rBZzDi/j8ni 1PXPbBb7OzsYHfg8fv+axOjxZNNFRo+ds+6ye+yZeJLNY9OqTjaPzUvqPa6caGL16G1+x+ax pR8o2bdlFaPH501yAdxRXDYpqTmZZalF+nYJXBmXfz9nK7jBXzF3/ST2BsY7PF2MnBwSAiYS e+52skLYYhIX7q1nA7GFBJYySlzeXdrFyAVkP2WU2Dp3G1ARB4ewQKrEpoXFIDUiAjYSnTvv skHUrGWUuDLpMBOIwyywnlmia+9VsElsAsYSm5cvYYPYICfR2z2JBcTmFdCSOPb9MFicRUBV 4tqCpWBXiApESBzu7GKHqBGU+DH5Hlg9p4CexJ09fewgRzAD2fcvaoGEmQXkJTavecs8gVFw FpKOWQhVs5BULWBkXsUomlqaXFCclJ5rpFecmFtcmpeul5yfu4kREnlfdzAuPWZ1iFGAg1GJ hzdj9eYwIdbEsuLK3EOMEhzMSiK8W+4ChXhTEiurUovy44tKc1KLDzFKc7AoifPO3PU+REgg PbEkNTs1tSC1CCbLxMEp1cCYrNqpl/z4jlT8J82E9X03HKoMOuZWsnY8e97Kl7dJM7wng5cv +kV99H0hH6ccleu/b1Xsdgvyn3zGeOmzj9MrRb0Dyu69Zpke2rdmy8ukOaf2PtNsPaJ7knlx xRz+h0d1WS6djdz3NpynYpHEyp8CvIce/AnbZauWvkKoPOb8mz8fir7vm7VQiaU4I9FQi7mo OBEAZ81OO7gCAAA= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05.02.2016 07:56, Alexandre Belloni wrote: > On 31/01/2016 at 21:11:00 +0900, Krzysztof Kozlowski wrote : >> W dniu 31.01.2016 o 21:05, Alexandre Belloni pisze: >>> Hi, >>> >>> On 27/01/2016 at 00:36:36 -0300, Javier Martinez Canillas wrote : >>>> Hello, >>>> >>>> On a recent disussion [0] with Krzysztof Kozlowski and Laxman Dewangan, >>>> we came to the conclusion that the max77686 and max77802 RTC are almost >>>> the same with only a few differences so there shouldn't be two separate >>>> drivers and is better to extend max77686 driver and delete rtc-max77802. >>>> >>>> By making the driver more generic, other RTC IP blocks from Maxim PMICs >>>> could be supported as well like the max77620. >>>> >>>> This is a v4 of a series that do this, that address issues pointed out >>>> in the latest version. The v1, v2 and v3 can be found at [1], [2], [3]. >>>> >>>> I've tested this patch-set on an Exynos5800 Peach Pi Chromebook that has >>>> a max77802 PMIC and the RTC was working correctly. Krzysztof Kozlowski >>>> tested v3 on an max77686 but this version only has cosmetic changes so >>>> it should not cause any functionality changes. >>>> >>>> [0]: http://www.spinics.net/lists/devicetree/msg110348.html >>>> [1]: https://lwn.net/Articles/672568/ >>>> [2]: https://lkml.org/lkml/2016/1/25/767 >>>> [3]: https://lkml.org/lkml/2016/1/26/787 >>>> >>> >>> I've applied patches 1 to 8 and I'll discussed with Arnd and Olof about >>> what I should do with the defconfig changes. >> >> To avoid conflicts they could go through samsung-soc tree. I could pick >> them if you provide me a tag with rest of patchset (dependencies). >> >> Would that be okay for you? >> > > Let's do that, I've prepared a tag, rtc-max77686-4.6 with all the > max77686 material collected until now. If I need to rebase rtc-next, > I'll rebase on top of that. Thanks, I pulled the tag, applied patches #9 and #10 and pushed out to the for-next. Best regards, Krzysztof