From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754093AbcBEOxf (ORCPT ); Fri, 5 Feb 2016 09:53:35 -0500 Received: from mail-wm0-f51.google.com ([74.125.82.51]:36038 "EHLO mail-wm0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750958AbcBEOxd (ORCPT ); Fri, 5 Feb 2016 09:53:33 -0500 Subject: Re: [RFC 1/4] lightnvm: precalculate controller write boundaries To: =?UTF-8?Q?Javier_Gonz=c3=a1lez?= References: <1454591299-30305-1-git-send-email-javier@javigon.com> <1454591299-30305-2-git-send-email-javier@javigon.com> Cc: linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, =?UTF-8?Q?Javier_Gonz=c3=a1lez?= From: =?UTF-8?Q?Matias_Bj=c3=b8rling?= Message-ID: <56B4B76B.6010007@lightnvm.io> Date: Fri, 5 Feb 2016 15:53:31 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <1454591299-30305-2-git-send-email-javier@javigon.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/04/2016 02:08 PM, Javier González wrote: > Flash controllers typically define flash pages as a collection of flash > sectors of typically 4K. Moreover, flash controllers might program flash > pages across several planes. This defines the write granurality at which > flash can be programmed. This is different for each flash controller. > > In order to simplify calculations, and avoid repeating them in a per-I/O > basis, this patch pre-calculates write granurality values as part of the > device characteristics in the bring up. > > Signed-off-by: Javier González > --- > drivers/lightnvm/rrpc.c | 4 ++++ > drivers/lightnvm/rrpc.h | 3 +++ > 2 files changed, 7 insertions(+) > > diff --git a/drivers/lightnvm/rrpc.c b/drivers/lightnvm/rrpc.c > index 775bf6c2..8187bf3 100644 > --- a/drivers/lightnvm/rrpc.c > +++ b/drivers/lightnvm/rrpc.c > @@ -1149,6 +1149,10 @@ static int rrpc_luns_init(struct rrpc *rrpc, int lun_begin, int lun_end) > if (!rrpc->luns) > return -ENOMEM; > > + rrpc->min_write_pgs = dev->sec_per_pl * (dev->sec_size / PAGE_SIZE); > + /* assume max_phys_sect % dev->min_write_pgs == 0 */ > + rrpc->max_write_pgs = dev->ops->max_phys_sect; > + > /* 1:1 mapping */ > for (i = 0; i < rrpc->nr_luns; i++) { > struct nvm_lun *lun = dev->mt->get_lun(dev, lun_begin + i); > diff --git a/drivers/lightnvm/rrpc.h b/drivers/lightnvm/rrpc.h > index 3989d65..868e91a 100644 > --- a/drivers/lightnvm/rrpc.h > +++ b/drivers/lightnvm/rrpc.h > @@ -107,6 +107,9 @@ struct rrpc { > unsigned long long nr_sects; > unsigned long total_blocks; > > + int min_write_pgs; /* minimum amount of pages required by controller */ > + int max_write_pgs; /* maximum amount of pages supported by controller */ > + > /* Write strategy variables. Move these into each for structure for each > * strategy > */ > This belongs to the write buffer patch.