From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752745AbcBHKpa (ORCPT ); Mon, 8 Feb 2016 05:45:30 -0500 Received: from r00tworld.com ([212.85.137.150]:47723 "EHLO r00tworld.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752134AbcBHKp1 (ORCPT ); Mon, 8 Feb 2016 05:45:27 -0500 From: "PaX Team" To: linux-tip-commits@vger.kernel.org, zhangyanfei@cn.fujitsu.com, wency@cn.fujitsu.com, tglx@linutronix.de, torvalds@linux-foundation.org, linux-kernel@vger.kernel.org, mingo@kernel.org, imtangchen@gmail.com, spender@grsecurity.net, hpa@zytor.com, tangchen@cn.fujitsu.com, y14sg1@comcast.net, isimatu.yasuaki@jp.fujitsu.com, akpm@linux-foundation.org, izumi.taku@jp.fujitsu.com, laijs@cn.fujitsu.com Date: Mon, 08 Feb 2016 11:36:05 +0100 MIME-Version: 1.0 Subject: Re: [tip:x86/mm] x86/mm/numa: Clean up numa_clear_kernel_node_hotplug () Reply-to: pageexec@freemail.hu CC: izumi.taku@jp.fujitsu.com, torvalds@linux-foundation.org, tglx@linutronix.de, akpm@linux-foundation.org, wency@cn.fujitsu.com, zhangyanfei@cn.fujitsu.com, isimatu.yasuaki@jp.fujitsu.com, y14sg1@comcast.net, tangchen@cn.fujitsu.com, hpa@zytor.com, laijs@cn.fujitsu.com, imtangchen@gmail.com, spender@grsecurity.net, mingo@kernel.org Message-ID: <56B86F95.12384.11AF6415@pageexec.freemail.hu> In-reply-to: References: X-mailer: Pegasus Mail for Windows (4.70) Content-type: text/plain; charset=US-ASCII Content-transfer-encoding: 7BIT Content-description: Mail message body X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-2.1.12 (r00tworld.com [212.85.137.150]); Mon, 08 Feb 2016 11:36:03 +0100 (CET) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8 Feb 2016 at 1:42, tip-bot for Ingo Molnar wrote: > for (i = 0; i < numa_meminfo.nr_blks; i++) { > - struct numa_memblk *mb = &numa_meminfo.blk[i]; > + struct numa_memblk *mb = numa_meminfo.blk + i; > > - memblock_set_node(mb->start, mb->end - mb->start, > - &memblock.reserved, mb->nid); > + memblock_set_node(mb->start, mb->end-mb->start, &memblock.reserved, mb->nid); if you're not keeping to the 80-char length (no complaints from me on that), could you also use some whitespace around the '-' operator for more readability?