From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753222AbcBIF2L (ORCPT ); Tue, 9 Feb 2016 00:28:11 -0500 Received: from hqemgate15.nvidia.com ([216.228.121.64]:2037 "EHLO hqemgate15.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751348AbcBIF2J (ORCPT ); Tue, 9 Feb 2016 00:28:09 -0500 X-PGP-Universal: processed; by hqnvupgp08.nvidia.com on Mon, 08 Feb 2016 21:28:34 -0800 Message-ID: <56B97632.1000208@nvidia.com> Date: Tue, 9 Feb 2016 10:46:34 +0530 From: Laxman Dewangan User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 MIME-Version: 1.0 To: Mark Brown CC: Thomas Gleixner , , , , , , , , , Subject: Re: [PATCH V4 1/6] regmap: irq: add apis to unmap the mapped irq References: <1454769447-785-1-git-send-email-ldewangan@nvidia.com> <1454769447-785-2-git-send-email-ldewangan@nvidia.com> <20160208145550.GE7265@sirena.org.uk> <56B8C484.7000309@nvidia.com> <20160208165912.GK7265@sirena.org.uk> <56B8C8B4.4050207@nvidia.com> <20160208181908.GM7265@sirena.org.uk> In-Reply-To: <20160208181908.GM7265@sirena.org.uk> X-Originating-IP: [10.19.65.30] X-ClientProxiedBy: DRUKMAIL102.nvidia.com (10.25.59.20) To bgmail102.nvidia.com (10.25.59.11) Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Monday 08 February 2016 11:49 PM, Mark Brown wrote: > * PGP Signed by an unknown key > > On Mon, Feb 08, 2016 at 10:26:20PM +0530, Laxman Dewangan wrote: > >> So fix need to go in the irq_domain_remove() to unamp before actually >> destroying the irq domain? > That's one option, but you could also do this at the regmap-irq level. > Do we need to dispose all virtual irq in regmap_del_irq_chip() before actually removing domain? This means we need to store the created virq in regmap_irq_chip_data for disposing it when removing the irq domain.