From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755867AbcBIX2f (ORCPT <rfc822;w@1wt.eu>);
	Tue, 9 Feb 2016 18:28:35 -0500
Received: from mail-pf0-f174.google.com ([209.85.192.174]:33464 "EHLO
	mail-pf0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753374AbcBIX2d (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 9 Feb 2016 18:28:33 -0500
Subject: Re: [PATCH] scsi: fdomain: add missing CONFIG_ to PCMCIA
To: One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk>
References: <1455056209-1696-1-git-send-email-yang.shi@linaro.org>
 <20160209232510.0c38ff77@lxorguk.ukuu.org.uk>
Cc: JBottomley@odin.com, martin.petersen@oracle.com,
        linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org,
        linaro-kernel@lists.linaro.org
From: "Shi, Yang" <yang.shi@linaro.org>
Message-ID: <56BA761F.4000305@linaro.org>
Date: Tue, 9 Feb 2016 15:28:31 -0800
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101
 Thunderbird/38.5.1
MIME-Version: 1.0
In-Reply-To: <20160209232510.0c38ff77@lxorguk.ukuu.org.uk>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2/9/2016 3:25 PM, One Thousand Gnomes wrote:
> On Tue,  9 Feb 2016 14:16:49 -0800
> Yang Shi <yang.shi@linaro.org> wrote:
>
>> There are some "#ifdef PCMCIA" in the driver code, but all of them missed
>> CONFIG_ prefix. Correct PCMCIA to CONFIG_PCMCIA.
>>
>> Signed-off-by: Yang Shi <yang.shi@linaro.org>
>
> NAK. This breaks the driver completely
>
>
> Read drivers/scsi/pcmcia/fdomain*

Got it. Thanks for spotting out this. Sorry for the unthought change.

Yang

>
> Alan
>