From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751872AbcBKLEb (ORCPT ); Thu, 11 Feb 2016 06:04:31 -0500 Received: from foss.arm.com ([217.140.101.70]:53192 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751148AbcBKLE3 (ORCPT ); Thu, 11 Feb 2016 06:04:29 -0500 Subject: Re: [PATCH] of/irq: Fix msi-map calculation for nonzero rid-base To: Robin Murphy , robh+dt@kernel.org, frowand.list@gmail.com, grant.likely@linaro.org, devicetree@vger.kernel.org References: <9f6845195d03b0e0b0d187bb510fbf7bd497e836.1455015344.git.robin.murphy@arm.com> Cc: mark.rutland@arm.com, david.daney@cavium.com, stuart.yoder@nxp.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org From: Marc Zyngier Organization: ARM Ltd Message-ID: <56BC6ABA.5020605@arm.com> Date: Thu, 11 Feb 2016 11:04:26 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Icedove/38.5.0 MIME-Version: 1.0 In-Reply-To: <9f6845195d03b0e0b0d187bb510fbf7bd497e836.1455015344.git.robin.murphy@arm.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/02/16 11:04, Robin Murphy wrote: > The existing msi-map code is fine for shifting the entire RID space > upwards, but attempting finer-grained remapping reveals a bug. It turns > out that we are mistakenly treating the msi-base part as an offset, not > as a new base to remap onto, so things get squiffy when rid-base is > nonzero. Fix this, and at the same time add a sanity check against > having msi-map-mask clash with a nonzero rid-base, as that's another > thing one can easily get wrong. > > CC: > Signed-off-by: Robin Murphy Rob, Frank, Are you willing to take this one through the OF tree? Or should we route it through the IRQ tree? It'd be good if it make it into 4.5. Thanks, M. -- Jazz is not dead. It just smells funny...