From: Sudeep Holla <sudeep.holla@arm.com>
To: Jassi Brar <jassisinghbrar@gmail.com>
Cc: Sudeep Holla <sudeep.holla@arm.com>,
Lee Jones <lee.jones@linaro.org>,
Devicetree List <devicetree@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 0/4] mailbox: mailbox-test: support single channel with separate Tx and Rx buffer
Date: Mon, 15 Feb 2016 12:38:30 +0000 [thread overview]
Message-ID: <56C1C6C6.6060108@arm.com> (raw)
In-Reply-To: <CABb+yY20VRzHa540c6guAJS-U3Y5XFCbAYAWwSLT3ugOJRYmfw@mail.gmail.com>
On 15/02/16 12:31, Jassi Brar wrote:
> On Mon, Feb 15, 2016 at 5:47 PM, Sudeep Holla <sudeep.holla@arm.com> wrote:
>> Hi Jassi,
>>
>> On 11/02/16 17:13, Sudeep Holla wrote:
>>>
>>> Hi Lee, Jassi,
>>>
>>> Assuming mailbox-test was designed to be generic, I am trying to extend
>>> it to support single channel with separate Tx and Rx buffer. With these
>>> changes I am able to test arm_mhu driver. However I couldn't understand
>>> the intention of converting buffer to ASCII hex dump in read method.
>>> I have a local change to remove that so that it can deal with any data
>>> in any format(e.g. some protocol format) and userspace can deal with the
>>> actual interpretation of the data. Let me know your thoughts on that.
>>>
>>
>> Can you review this ? It would be good to get this in for v4.6
>>
> Seems simple enough. So once you and Lee are in sync...
>
That was quick :). Anyways IIUC Lee agrees with most of the changes.
The question I am asking is not part of this series, I didn't make the
change to remove hexdump yet, I am trying to understand the reasoning
for doing that and also explaining my requirement as why I want to
remove it.
--
Regards,
Sudeep
prev parent reply other threads:[~2016-02-15 12:38 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-11 17:13 Sudeep Holla
2016-02-11 17:13 ` [PATCH 1/4] mailbox: mailbox-test: rename driver as generic test driver Sudeep Holla
2016-02-12 9:08 ` Lee Jones
2016-02-11 17:13 ` [PATCH 2/4] mailbox: mailbox-test: fix the compatible string Sudeep Holla
2016-02-12 9:08 ` Lee Jones
2016-02-12 16:49 ` Rob Herring
2016-02-11 17:13 ` [PATCH 3/4] mailbox: mailbox-test: use print_hex_dump_bytes to allow dynamic printk Sudeep Holla
2016-02-12 9:12 ` Lee Jones
2016-02-12 9:32 ` Sudeep Holla
2016-02-11 17:13 ` [PATCH 4/4] mailbox: mailbox-test: add support for separate tx/rx buffer with single channel Sudeep Holla
2016-02-12 9:15 ` Lee Jones
2016-02-12 9:34 ` Sudeep Holla
2016-02-12 9:17 ` [PATCH 0/4] mailbox: mailbox-test: support single channel with separate Tx and Rx buffer Lee Jones
2016-02-12 9:41 ` Sudeep Holla
2016-02-15 12:14 ` Sudeep Holla
2016-02-15 12:17 ` Sudeep Holla
2016-02-15 12:31 ` Jassi Brar
2016-02-15 12:38 ` Sudeep Holla [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56C1C6C6.6060108@arm.com \
--to=sudeep.holla@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=jassisinghbrar@gmail.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome