From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932650AbcBPOeN (ORCPT ); Tue, 16 Feb 2016 09:34:13 -0500 Received: from lists.s-osg.org ([54.187.51.154]:48512 "EHLO lists.s-osg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932530AbcBPOeL (ORCPT ); Tue, 16 Feb 2016 09:34:11 -0500 Subject: Re: [PATCH] rtc: s5m: De-inline large functions to save space To: Krzysztof Kozlowski , Sangbeom Kim , Alessandro Zummo , Alexandre Belloni , linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, rtc-linux@googlegroups.com References: <1455588282-7251-1-git-send-email-k.kozlowski@samsung.com> Cc: Denys Vlasenko From: Javier Martinez Canillas Message-ID: <56C33358.7040807@osg.samsung.com> Date: Tue, 16 Feb 2016 11:34:00 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 MIME-Version: 1.0 In-Reply-To: <1455588282-7251-1-git-send-email-k.kozlowski@samsung.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Krzysztof, On 02/15/2016 11:04 PM, Krzysztof Kozlowski wrote: > Few functions were marked inline even though they were relatively large > and sometimes used in multiple places. De-inline them to let the > compiler decide whether optimization makes sense. This fixes inline_hunt > report: > drivers/rtc/rtc-s5m.c: Deinline s5m8767_rtc_set_alarm_reg, save 704 bytes > drivers/rtc/rtc-s5m.c: Deinline s5m8767_wait_for_udr_update, save 192 bytes > > Reported-by: Denys Vlasenko > Cc: Denys Vlasenko > Signed-off-by: Krzysztof Kozlowski Reviewed-by: Javier Martinez Canillas Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America