From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161547AbcBQSjN (ORCPT ); Wed, 17 Feb 2016 13:39:13 -0500 Received: from lists.s-osg.org ([54.187.51.154]:49131 "EHLO lists.s-osg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965424AbcBQSjJ (ORCPT ); Wed, 17 Feb 2016 13:39:09 -0500 Subject: Re: [PATCH 2/4] mfd: max77686: Use module_i2c_driver() instead of subsys initcall To: Krzysztof Kozlowski , linux-kernel@vger.kernel.org References: <1455251419-8919-1-git-send-email-javier@osg.samsung.com> <1455251419-8919-3-git-send-email-javier@osg.samsung.com> <56C1762E.9040208@samsung.com> <56C1ED07.6090008@osg.samsung.com> <56C25D55.5040208@samsung.com> <56C38A78.2090601@osg.samsung.com> <56C4260E.5010808@samsung.com> Cc: Andi Shyti , linux-samsung-soc@vger.kernel.org, Lee Jones , Laxman Dewangan , Marek Szyprowski From: Javier Martinez Canillas Message-ID: <56C4BE43.9090005@osg.samsung.com> Date: Wed, 17 Feb 2016 15:38:59 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 MIME-Version: 1.0 In-Reply-To: <56C4260E.5010808@samsung.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Krzysztof, On 02/17/2016 04:49 AM, Krzysztof Kozlowski wrote: > On 17.02.2016 05:45, Javier Martinez Canillas wrote: [snip] >>> >>> By "please check" in this case I mean - look if every regulator/clock >>> consumer using stuff exposed by PMIC, supports properly deferred probing. >>> >> >> Got it, I checked and all but one consumer driver that use resources >> provided by the max77686 defer probe when this is not found AFAICT. >> >> Clocks: >> >> drivers/mmc/core/pwrseq_simple.c >> drivers/rtc/rtc-s3c.c >> >> Regulators: >> >> drivers/cpufreq/cpufreq-dt.c >> drivers/gpu/drm/exynos/exynos_drm_dsi.c >> drivers/gpu/drm/exynos/exynos_hdmi.c >> drivers/gpu/drm/panel/panel-samsung-s6e8aa0.c >> drivers/iio/adc/exynos_adc.c >> drivers/input/misc/max77693-haptic.c >> drivers/input/touchscreen/mms114.c >> drivers/media/i2c/s5c73m3/s5c73m3-core.c >> drivers/media/i2c/s5k6a3.c >> drivers/media/platform/exynos4-is/mipi-csis.c >> drivers/mfd/wm8994-core.c >> drivers/mmc/host/dw_mmc.c >> drivers/mmc/host/sdhci.c >> drivers/usb/dwc2/platform.c >> >> The only driver that does not defer probe when an input supply >> isn't found is drivers/thermal/samsung/exynos_tmu.c (vtmu-supply). >> >> So that should be handled before this series are merged. > > Thanks for the analysis. Indeed the exynos_tmu does not support probe > deferral. Instead it just ignores the error and skips the regulator. It > would be good to fix this before applying this patch. > Ok. I'll take care of that, probably tomorrow. > Rest looks indeed good so I don't have objections (beside tmu case). > Thanks a lot for your feedback and suggestions. > Best regards, > Krzysztof > -- Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America