From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1426170AbcBRMyh (ORCPT ); Thu, 18 Feb 2016 07:54:37 -0500 Received: from mx1.redhat.com ([209.132.183.28]:51866 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1425294AbcBRMyH (ORCPT ); Thu, 18 Feb 2016 07:54:07 -0500 Subject: Re: [PATCH v2 1/2] mpt3sas: Free memory pools before retrying to allocate with different value. To: Suganath Prabu Subramani , JBottomley@Parallels.com, jejb@kernel.org, hch@infradead.org References: <1455784786-19086-1-git-send-email-suganath-prabu.subramani@broadcom.com> Cc: martin.petersen@oracle.com, linux-scsi@vger.kernel.org, Sathya.Prakash@broadcom.com, kashyap.desai@broadcom.com, krishnaraddi.mankani@broadcom.com, linux-kernel@vger.kernel.org, chaitra.basappa@broadcom.com, sreekanth.reddy@broadcom.com, Suganath prabu Subramani From: Tomas Henzl Message-ID: <56C5BEEA.7030004@redhat.com> Date: Thu, 18 Feb 2016 13:54:02 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 MIME-Version: 1.0 In-Reply-To: <1455784786-19086-1-git-send-email-suganath-prabu.subramani@broadcom.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 18.2.2016 09:39, Suganath Prabu Subramani wrote: > From: Suganath prabu Subramani > > Deallocate resources before reallocating of the same in retry_allocation > path of _base_allocate_memory_pools() > > Signed-off-by: Suganath prabu Subramani > Signed-off-by: Chaitra P B > --- > drivers/scsi/mpt3sas/mpt3sas_base.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/scsi/mpt3sas/mpt3sas_base.c b/drivers/scsi/mpt3sas/mpt3sas_base.c > index afdb13a..5bbbbf2 100644 > --- a/drivers/scsi/mpt3sas/mpt3sas_base.c > +++ b/drivers/scsi/mpt3sas/mpt3sas_base.c > @@ -3414,6 +3414,7 @@ _base_allocate_memory_pools(struct MPT3SAS_ADAPTER *ioc, int sleep_flag) > goto out; > retry_sz = 64; > ioc->hba_queue_depth -= retry_sz; > + _base_release_memory_pools(ioc); > goto retry_allocation; > } > Reviewed-by: Tomas Henzl