From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1423843AbcBSDwB (ORCPT ); Thu, 18 Feb 2016 22:52:01 -0500 Received: from mailout3.w1.samsung.com ([210.118.77.13]:12820 "EHLO mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1423660AbcBSDv4 (ORCPT ); Thu, 18 Feb 2016 22:51:56 -0500 X-AuditID: cbfec7f4-f79026d00000418a-a5-56c691597ad3 Subject: Re: [PATCH v2 1/3] ARM: dts: Add cooling levels for CPUs on exynos5420 To: Punit Agrawal References: <1455772383-20598-1-git-send-email-k.kozlowski@samsung.com> <87h9h599zi.fsf@e105922-lin.cambridge.arm.com> Cc: Kukjin Kim , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, Lukasz Majewski , Zhang Rui , Eduardo Valentin , Viresh Kumar From: Krzysztof Kozlowski X-Enigmail-Draft-Status: N1110 Message-id: <56C69154.40608@samsung.com> Date: Fri, 19 Feb 2016 12:51:48 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-version: 1.0 In-reply-to: <87h9h599zi.fsf@e105922-lin.cambridge.arm.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupmkeLIzCtJLcpLzFFi42I5/e/4Nd3IicfCDF7ME7CYf+Qcq8X8K9dY LV6/MLTof/ya2eLNw82MFpseA4Uu75rDZvG59wijxYzz+5gsnr8/zWTx5GEfm8XGrx4OPB5r 5q1h9Ng56y67x+I9L5k8Nq3qZPO4c20Pm8fmJfUefVtWMXp83iQXwBHFZZOSmpNZllqkb5fA lXHn7GHmggaeildLnjI3MH7g7GLk5JAQMJGYf/ESM4QtJnHh3nq2LkYuDiGBpYwSz09MZIdw njJKTHn0jg2kSljAX+LQ+89gtoiApsS+W6eZQGwhgQqJJxPPMII0MAs8ZJKYvb6HFSTBJmAs sXn5EjaIFXISvd2TWLoYOTh4BTQk3m6IBwmzCKhK3OxYAlYuKhAhcbizix3E5hUQlPgx+R4L iM0pYC0xoXMRK0grs4CexP2LWiBhZgF5ic1r3jJPYBSchaRjFkLVLCRVCxiZVzGKppYmFxQn peca6hUn5haX5qXrJefnbmKERNGXHYyLj1kdYhTgYFTi4b1gcCxMiDWxrLgy9xCjBAezkgiv rj9QiDclsbIqtSg/vqg0J7X4EKM0B4uSOO/cXe9DhATSE0tSs1NTC1KLYLJMHJxSDYz9PLKz kh/295/ilvtw9lPuxczjYQ9eLc11VJRn4zCd/reubkfjz/cf3iqeN9gYy5fH+uPDO8k5188c 7zrO2259aGH0Vx+HQ2c42dZZ6mz8GnN7+taPraVLg8y6bGTkLkR+ue7Qu0N+Z/2Hl262Vys2 cKYHrlHc/fbp7lDXsr933rvdW5N4uOqPEktxRqKhFnNRcSIAME8T5Z4CAAA= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 19.02.2016 02:58, Punit Agrawal wrote: > Hi Krzysztof, > > Krzysztof Kozlowski writes: > >> On Exynos5420 we support 8 cpufreq steps (600-1300 MHz) for LITTLE and >> 12 steps for big core (700-1800 MHz). Add respective cooling cells. >> >> Signed-off-by: Krzysztof Kozlowski >> >> --- >> >> Changes since v1: >> 1. Add cooling properties to all CPUs (suggested by Viresh). >> --- >> arch/arm/boot/dts/exynos5420-cpus.dtsi | 24 ++++++++++++++++++++++++ >> 1 file changed, 24 insertions(+) >> >> diff --git a/arch/arm/boot/dts/exynos5420-cpus.dtsi b/arch/arm/boot/dts/exynos5420-cpus.dtsi >> index 261d25173f61..5c052d7ff554 100644 >> --- a/arch/arm/boot/dts/exynos5420-cpus.dtsi >> +++ b/arch/arm/boot/dts/exynos5420-cpus.dtsi >> @@ -33,6 +33,9 @@ >> clock-frequency = <1800000000>; >> cci-control-port = <&cci_control1>; >> operating-points-v2 = <&cluster_a15_opp_table>; >> + cooling-min-level = <0>; >> + cooling-max-level = <11>; > > Although the above two properties are defined they aren't parsed in the > kernel. > > Setting min / max extents for cooling devices via cooling maps does work > though. It is described as optional property in Documentation/devicetree/bindings/thermal/thermal.txt ... but indeed it is totally ignored. So what is the recommendation? Get rid of it from DTS and documentation or leave it because it will be implemented someday? Thanks for feedback! Best regards, Krzysztof