From: Laxman Dewangan <ldewangan@nvidia.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Alexandre Courbot <gnurou@gmail.com>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/1] gpio: add devm_ apis for gpio_chip_add and remove
Date: Sat, 20 Feb 2016 09:34:46 +0530 [thread overview]
Message-ID: <56C7E5DE.30505@nvidia.com> (raw)
In-Reply-To: <CACRpkdYGS1DogPDnY87HsN2PzDVHw-h6Y15Gv8qhLzgKrkMJtQ@mail.gmail.com>
On Tuesday 16 February 2016 08:33 PM, Linus Walleij wrote:
> On Mon, Feb 15, 2016 at 2:17 PM, Laxman Dewangan <ldewangan@nvidia.com> wrote:
>
>> Add device managed APIs devm_gpiochip_add_data() and
>> devm_gpiochip_remove() for the APIs gpiochip_add_data()
>> and gpiochip_remove().
>>
>> This helps in reducing code in error path and sometimes
>> removal of .remove callback for driver unbind.
>>
>> Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
> I like the looks of this.
>
> One comment: you must also patch
> Documentation/driver-model/devres.txt
Sure,
>
> Will you also follow up with a massive patch set making use of
> this new API? I feel bad about merging an API if it's not used.
>
> Thanks for only supporting this for the new _data() function.
>
>
Yes, I have planned for this to use this new API. This is just for
getting review whether fine or not to have devm_* APIs so that I can
make changes on rest of driver to use this new APIs.
prev parent reply other threads:[~2016-02-20 4:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-15 13:17 Laxman Dewangan
2016-02-16 15:03 ` Linus Walleij
2016-02-20 4:04 ` Laxman Dewangan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56C7E5DE.30505@nvidia.com \
--to=ldewangan@nvidia.com \
--cc=gnurou@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome