From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758685AbcBXSao (ORCPT ); Wed, 24 Feb 2016 13:30:44 -0500 Received: from hq.vniiem.ru ([78.107.120.166]:48686 "EHLO mx.svc.vniiem.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758437AbcBXSal (ORCPT ); Wed, 24 Feb 2016 13:30:41 -0500 Subject: Re: [PATCH v2 0/3] PCI: Revert "Implement pcibios_alloc_irq() and pcibios_free_irq()" To: Bjorn Helgaas References: <20160217182718.302.10272.stgit@bhelgaas-glaptop2.roam.corp.google.com> <56C55305.2050404@mcc.vniiem.ru> <20160218160319.GC17588@localhost> Cc: Bjorn Helgaas , linux-pci@vger.kernel.org, Joerg Roedel , "Rafael J. Wysocki" , linux-kernel@vger.kernel.org, Sunjin Yang , linux-acpi@vger.kernel.org, Thomas Gleixner , Yinghai Lu , Jiang Liu From: =?UTF-8?B?0J7Qu9C10LMg0JzQvtGA0L7Qtw==?= Message-ID: <56CDF6E0.2060005@mcc.vniiem.ru> Date: Wed, 24 Feb 2016 21:30:56 +0300 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <20160218160319.GC17588@localhost> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I've checked next next-20160218 tag and confirm that it works. 18.02.2016 19:03, Bjorn Helgaas пишет: > On Thu, Feb 18, 2016 at 08:13:41AM +0300, Мороз Олег wrote: >> On 17.02.2016 21:36, Bjorn Helgaas wrote: >>> These are clean reverts of 991de2e59090 ("PCI, x86: Implement >>> pcibios_alloc_irq() and pcibios_free_irq()") and related changes. >>> >>> We have two reports of drivers broken in v4.3 by Jiang's change, >>> 991de2e59090 ("PCI, x86: Implement pcibios_alloc_irq() and >>> pcibios_free_irq()"). >>> >>> It would be best to fix the problem instead of reverting 991de2e59090, but >>> I don't have time to do that myself, and we haven't heard from Jiang, so >>> the only choice I have is to revert the commit. >>> >>> Note that reverting will likely break IOAPIC hotplug. >>> >>> Олег and Sunjin, can you please test this and see whether it fixes your >>> drivers? This patch is based on v4.5-rc1. >>> >>> I intend to merge these for v4.5 unless I hear objections. >>> >>> They're on my for-linus branch, so they should appear in linux-next >>> tomorrow. >>> >>> Changes from the v1 posting: >>> - Explicitly revert related patches instead of resolving conflicts >>> manually >>> --- >>> >>> Bjorn Helgaas (3): >>> Revert "x86/PCI: Don't alloc pcibios-irq when MSI is enabled" >>> Revert "PCI: Add helpers to manage pci_dev->irq and pci_dev->irq_managed" >>> Revert "PCI, x86: Implement pcibios_alloc_irq() and pcibios_free_irq()" >>> >>> >>> arch/x86/include/asm/pci_x86.h | 2 ++ >>> arch/x86/pci/common.c | 26 ++++++++++---------------- >>> arch/x86/pci/intel_mid_pci.c | 9 +++------ >>> arch/x86/pci/irq.c | 23 +++++++++++++++++++---- >>> drivers/acpi/pci_irq.c | 17 +++++++++++++---- >>> include/linux/pci.h | 17 ----------------- >>> 6 files changed, 47 insertions(+), 47 deletions(-) >> As i undestand this patch will appear in kernel git repo tomorrow? I >> don't need to apply in manyally to v4.5-rc1? > These are included in the next-20160218 tag in the linux-next git repo (not > Linus' repo) at: > > git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git > > You browse this at: > > https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/ > > If you'd rather, you can also apply the patches yourself to v4.5-rc1. > > Bjorn