From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759513AbcBYCQy (ORCPT ); Wed, 24 Feb 2016 21:16:54 -0500 Received: from tama50.ecl.ntt.co.jp ([129.60.39.147]:47813 "EHLO tama50.ecl.ntt.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759309AbcBYCQw (ORCPT ); Wed, 24 Feb 2016 21:16:52 -0500 Subject: Re: [PATCH 09/12] KVM: MMU: coalesce zapping page after mmu_sync_children References: <1456319873-34182-1-git-send-email-pbonzini@redhat.com> <1456319873-34182-10-git-send-email-pbonzini@redhat.com> From: Takuya Yoshikawa Message-ID: <56CE63D1.40009@lab.ntt.co.jp> Date: Thu, 25 Feb 2016 11:15:45 +0900 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <1456319873-34182-10-git-send-email-pbonzini@redhat.com> Content-Type: text/plain; charset=iso-2022-jp Content-Transfer-Encoding: 7bit To: Paolo Bonzini , linux-kernel@vger.kernel.org, kvm@vger.kernel.org Cc: guangrong.xiao@linux.intel.com, mtosatti@redhat.com X-TM-AS-MML: disable Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2016/02/24 22:17, Paolo Bonzini wrote: > Move the call to kvm_mmu_flush_or_zap outside the loop. > > Signed-off-by: Paolo Bonzini > --- > arch/x86/kvm/mmu.c | 9 ++++++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > > diff --git a/arch/x86/kvm/mmu.c b/arch/x86/kvm/mmu.c > index 725316df32ec..6d47b5c43246 100644 > --- a/arch/x86/kvm/mmu.c > +++ b/arch/x86/kvm/mmu.c > @@ -2029,24 +2029,27 @@ static void mmu_sync_children(struct kvm_vcpu *vcpu, > struct mmu_page_path parents; > struct kvm_mmu_pages pages; > LIST_HEAD(invalid_list); > + bool flush = false; > > while (mmu_unsync_walk(parent, &pages)) { > bool protected = false; > - bool flush = false; > > for_each_sp(pages, sp, parents, i) > protected |= rmap_write_protect(vcpu, sp->gfn); > > - if (protected) > + if (protected) { > kvm_flush_remote_tlbs(vcpu->kvm); > + flush = false; > + } > > for_each_sp(pages, sp, parents, i) { > flush |= kvm_sync_page(vcpu, sp, &invalid_list); > mmu_pages_clear_parents(&parents); > } > - kvm_mmu_flush_or_zap(vcpu, &invalid_list, false, flush); > cond_resched_lock(&vcpu->kvm->mmu_lock); This may release the mmu_lock before committing the zapping. Is it safe? If so, we may want to see the reason in the changelog. Takuya > } > + > + kvm_mmu_flush_or_zap(vcpu, &invalid_list, false, flush); > } > > static void __clear_sp_write_flooding_count(struct kvm_mmu_page *sp) >