From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932258AbcBZHgR (ORCPT ); Fri, 26 Feb 2016 02:36:17 -0500 Received: from mailout4.w1.samsung.com ([210.118.77.14]:32581 "EHLO mailout4.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932099AbcBZHgO (ORCPT ); Fri, 26 Feb 2016 02:36:14 -0500 X-AuditID: cbfec7f4-f79026d00000418a-b3-56d0006a951e Subject: Re: [RESPIN 2/6] drivers: memory: Add support for exynos SROM driver To: Pankaj Dubey , linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <1456389222-12738-1-git-send-email-pankaj.dubey@samsung.com> <1456389222-12738-3-git-send-email-pankaj.dubey@samsung.com> <56CFFDF0.9040107@samsung.com> Cc: kgene.kim@samsung.com, thomas.ab@samsung.com, olof@lixom.net, p.fedin@samsung.com, Kukjin Kim From: Krzysztof Kozlowski Message-id: <56D00065.6030507@samsung.com> Date: Fri, 26 Feb 2016 16:36:05 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-version: 1.0 In-reply-to: <56CFFDF0.9040107@samsung.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrBLMWRmVeSWpSXmKPExsVy+t/xa7pZDBfCDO5/57B4/cLQonfBVTaL /sevmS02Pb7GanF51xw2ixnn9zFZnLr+mc3i1aVVbBaLtn5ht+hYxujA5bFpVSebx+Yl9R5X TjSxevRtWcXo8XmTXABrFJdNSmpOZllqkb5dAlfGw38b2QvapComte9ha2BcKNrFyMkhIWAi 8XL9QRYIW0ziwr31bF2MXBxCAksZJd59+s0I4TxllNj/qJcJpEpYwFeitfUZE0hCRGAKo8TW GUehWlYwSpyc+oURpIpZoEzi4+mj7CA2m4CxxOblS9hAbF4BLYnNn7eBxVkEVCXWv9sMFhcV iJA43NnFDlEjKPFj8j2wmzgFtCU2tK8D2sYBNFNP4v5FLYjx8hKb17xlnsAoMAtJxyyEqllI qhYwMq9iFE0tTS4oTkrPNdQrTswtLs1L10vOz93ECAn/LzsYFx+zOsQowMGoxMMrceF8mBBr YllxZe4hRgkOZiURXq6/QCHelMTKqtSi/Pii0pzU4kOM0hwsSuK8c3e9DxESSE8sSc1OTS1I LYLJMnFwSjUwzk6/YHZ5yynBxh0Lijk2GJx0jXi9NsS1yc/P+RXPQj42Cc4THlHrZLbE3F3z YX716cvJd9VeyDNWzHlcIbNuXvJpq0ctyWcaI/SU7s2YGn3249WTc3Py5gfedjvWfvHSvwrP gMYQtl//Inim1n7t+WG7bv3Fk+v/JT85Pnfz+m9T1p1aee1KAacSS3FGoqEWc1FxIgBAsboE ewIAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 26.02.2016 16:25, Krzysztof Kozlowski wrote: > On 25.02.2016 17:33, Pankaj Dubey wrote: >> This patch adds Exynos SROM controller driver which will handle >> save restore of SROM registers during S2R. >> >> Signed-off-by: Pankaj Dubey >> Reviewed-by: Krzysztof Kozlowski >> [p.fedin@samsung.com: tested on SMDK5410] >> Tested-by: Pavel Fedin >> Signed-off-by: Kukjin Kim >> Signed-off-by: Krzysztof Kozlowski >> --- >> drivers/memory/Kconfig | 1 + >> drivers/memory/Makefile | 1 + >> drivers/memory/samsung/Kconfig | 12 +++ >> drivers/memory/samsung/Makefile | 1 + >> drivers/memory/samsung/exynos-srom.c | 175 +++++++++++++++++++++++++++++++++++ >> drivers/memory/samsung/exynos-srom.h | 51 ++++++++++ >> 6 files changed, 241 insertions(+) >> create mode 100644 drivers/memory/samsung/Kconfig >> create mode 100644 drivers/memory/samsung/Makefile >> create mode 100644 drivers/memory/samsung/exynos-srom.c >> create mode 100644 drivers/memory/samsung/exynos-srom.h >> >> diff --git a/drivers/memory/Kconfig b/drivers/memory/Kconfig >> index 6f31546..bcb1982 100644 >> --- a/drivers/memory/Kconfig >> +++ b/drivers/memory/Kconfig >> @@ -114,6 +114,7 @@ config JZ4780_NEMC >> the Ingenic JZ4780. This controller is used to handle external >> memory devices such as NAND and SRAM. >> >> +source "drivers/memory/samsung/Kconfig" >> source "drivers/memory/tegra/Kconfig" >> >> endif >> diff --git a/drivers/memory/Makefile b/drivers/memory/Makefile >> index 1c46af5..d100e40 100644 >> --- a/drivers/memory/Makefile >> +++ b/drivers/memory/Makefile >> @@ -16,4 +16,5 @@ obj-$(CONFIG_MVEBU_DEVBUS) += mvebu-devbus.o >> obj-$(CONFIG_TEGRA20_MC) += tegra20-mc.o >> obj-$(CONFIG_JZ4780_NEMC) += jz4780-nemc.o >> >> +obj-$(CONFIG_SAMSUNG_MC) += samsung/ >> obj-$(CONFIG_TEGRA_MC) += tegra/ >> diff --git a/drivers/memory/samsung/Kconfig b/drivers/memory/samsung/Kconfig >> new file mode 100644 >> index 0000000..c2cd45e >> --- /dev/null >> +++ b/drivers/memory/samsung/Kconfig >> @@ -0,0 +1,12 @@ >> +config SAMSUNG_MC >> + bool "SAMSUNG Exynos Memory Controller support" if COMPILE_TEST >> + default y >> + depends on ARCH_EXYNOS These two are not needed and they introduce issues (when COMPILE_TEST it should not depend on exynos and should not be in such case enabled by default). >> + help >> + This driver supports the Memory Controller (MC) hardwares found on >> + SAMSUNG Exynos SoCs. >> + > > if SAMSUNG_MC > >> +config EXYNOS_SROM >> + bool bool should be described with COMPILE_TEST >> + depends on (ARM && ARCH_EXYNOS && PM) || ((ARM || ARM64) && COMPILE_TEST) > > (ARM && ARCH_EXYNOS && PM) || COMPILE_TEST > > You don't need to limit compile testing to ARM/ARM64. > So overall it should be like: config SAMSUNG_MC bool "Samsung Exynos Memory Controller support" if COMPILE_TEST help Support for the Memory Controller (MC) devices found on Samsung Exynos SoCs. if SAMSUNG_MC config EXYNOS_SROM bool "Exynos SROM controller driver" if COMPILE_TEST depends on (ARM && ARCH_EXYNOS && PM) || COMPILE_TEST endif