From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757322AbcB1K6v (ORCPT ); Sun, 28 Feb 2016 05:58:51 -0500 Received: from mail-wm0-f54.google.com ([74.125.82.54]:37899 "EHLO mail-wm0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757218AbcB1K6s (ORCPT ); Sun, 28 Feb 2016 05:58:48 -0500 Subject: Re: [PATCH] configfs: switch ->default groups to a linked list To: Christoph Hellwig , jlbec@evilplan.org References: <1456490031-7132-1-git-send-email-hch@lst.de> Cc: balbi@kernel.org, laurent.pinchart@ideasonboard.com, target-devel@vger.kernel.org, linux-usb@vger.kernel.org, linux-rdma@vger.kernel.org, cluster-devel@redhat.com, ocfs2-devel@oss.oracle.com, linux-kernel@vger.kernel.org From: Sagi Grimberg Message-ID: <56D2D2E2.3000200@dev.mellanox.co.il> Date: Sun, 28 Feb 2016 12:58:42 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <1456490031-7132-1-git-send-email-hch@lst.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 26/02/2016 14:33, Christoph Hellwig wrote: > Replace the current NULL-terminated array of default groups with a linked > list. This gets rid of lots of nasty code to size and/or dynamically > allocate the array. > > While we're at it also provide a conveniant helper to remove the default > groups. > > Signed-off-by: Christoph Hellwig > --- Nice! > -As a consequence of this, default_groups cannot be removed directly via > +As a consequence of this, default groups cannot be removed directly via > rmdir(2). They also are not considered when rmdir(2) on the parent > group is checking for children. > What's changed here? Other than that, looks good Reviewed-by: Sagi Grimberg