From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752473AbcCAH5k (ORCPT ); Tue, 1 Mar 2016 02:57:40 -0500 Received: from mx2.suse.de ([195.135.220.15]:36690 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750913AbcCAH5j (ORCPT ); Tue, 1 Mar 2016 02:57:39 -0500 Subject: Re: [PATCH v5 14/15] scsi: ufs: add device quirk delay before putting UFS rails in LPM To: Yaniv Gardi , James.Bottomley@HansenPartnership.com References: <1456666367-11418-1-git-send-email-ygardi@codeaurora.org> <1456666367-11418-15-git-send-email-ygardi@codeaurora.org> Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, linux-arm-msm@vger.kernel.org, santoshsy@gmail.com, linux-scsi-owner@vger.kernel.org, Subhash Jadavani , Vinayak Holikatti , "James E.J. Bottomley" , "Martin K. Petersen" From: Hannes Reinecke Message-ID: <56D54B5F.9070204@suse.de> Date: Tue, 1 Mar 2016 15:57:19 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <1456666367-11418-15-git-send-email-ygardi@codeaurora.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/28/2016 09:32 PM, Yaniv Gardi wrote: > We put the UFS device in sleep state & UFS link in hibern8 state during > runtime suspaned. After this we put all the UFS rails in low power > modes immediately but it seems some devices may still draw more than > sleep current from UFS rails (especially from VCCQ rail) atleast for > 500us. > To avoid this situation, this change adds 2ms delay before putting > these UFS rails in LPM mode. > > Reviewed-by: Gilad Broner > Signed-off-by: Subhash Jadavani > Signed-off-by: Yaniv Gardi > > --- > drivers/scsi/ufs/ufs_quirks.c | 4 ++++ > drivers/scsi/ufs/ufs_quirks.h | 11 ++++++++++- > drivers/scsi/ufs/ufshcd.c | 10 ++++++++++ > 3 files changed, 24 insertions(+), 1 deletion(-) > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage hare@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)