From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753340AbcCALS2 (ORCPT ); Tue, 1 Mar 2016 06:18:28 -0500 Received: from mx2.suse.de ([195.135.220.15]:43296 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751976AbcCALS0 (ORCPT ); Tue, 1 Mar 2016 06:18:26 -0500 Subject: Re: [PATCH 7/8] ARM64: dts: amlogic: Extend GXBaby GIC node To: Andre Przywara , linux-meson@googlegroups.com References: <1456789465-2962-1-git-send-email-afaerber@suse.de> <1456789465-2962-8-git-send-email-afaerber@suse.de> <56D57673.8030702@arm.com> Cc: Mark Rutland , devicetree , Matthias Brugger , Pawel Moll , Ian Campbell , Catalin Marinas , Nicolas Saenz , Will Deacon , LKML , Rob Herring , Kumar Gala , Carlo Caione , linux-arm-kernel@lists.infradead.org From: =?UTF-8?Q?Andreas_F=c3=a4rber?= X-Enigmail-Draft-Status: N1110 Organization: SUSE Linux GmbH Message-ID: <56D57A7F.5020806@suse.de> Date: Tue, 1 Mar 2016 12:18:23 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <56D57673.8030702@arm.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Andre, Am 01.03.2016 um 12:01 schrieb Andre Przywara: > On 29/02/16 23:44, Andreas Färber wrote: >> Add GICH and GICV resources for HYP mode - guess based on other vendors. > > Do you know if the firmware allows the kernel to be entered in EL2 > (which is the arm64 name for HYP)? > So can we run kvm? > If you have a booted kernel, can you grep for "EL2" and "kvm" in the dmesg? I do not have a rootfs yet (MMC v5 patches by Carlo are still waiting for review), but with this change the KVM driver initializes okay - the purpose of this patch! > Also you should merge this patch into 3/8, same for 8/8. If people confirm this is generally or specifically for this SoC correct then sure. So far 3/8 seems a safe subset for lack of public documentation. >> Signed-off-by: Andreas Färber >> --- >> arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi | 4 +++- >> 1 file changed, 3 insertions(+), 1 deletion(-) >> >> diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi >> index 0ae089bd1806..5088ae3ff653 100644 >> --- a/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi >> +++ b/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi >> @@ -117,7 +117,9 @@ >> gic: interrupt-controller@c4301000 { >> compatible = "arm,cortex-a15-gic", "arm,cortex-a9-gic"; > > I think "arm,gic-400" is the name to use here these days, especially for > arm64. I took what /proc/device-tree showed on Android and verified that this compatible is in use in mainline. >> reg = <0x0 0xc4301000 0 0x1000>, >> - <0x0 0xc4302000 0 0x0100>; >> + <0x0 0xc4302000 0 0x0100>, > > Please use 0x2000 for the size here. I guess this is really the GIC-400 > from ARM, and in this case this is the right size, [1] is the reference > here. This will enable EOI mode 1 for KVM. Will test later. Is there any easy way to find out whether or not this is that GIC-400? Thanks, Andreas > [1] > http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.ddi0471b/CHDIFAEE.html > >> + <0x0 0xc4304000 0 0x2000>, >> + <0x0 0xc4306000 0 0x2000>; >> interrupt-controller; >> interrupts = > (GIC_CPU_MASK_SIMPLE(8) | IRQ_TYPE_LEVEL_HIGH)>; -- SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Felix Imendörffer, Jane Smithard, Graham Norton; HRB 21284 (AG Nürnberg)