From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753455AbcCAL7b (ORCPT ); Tue, 1 Mar 2016 06:59:31 -0500 Received: from mx2.suse.de ([195.135.220.15]:48964 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752995AbcCAL7a (ORCPT ); Tue, 1 Mar 2016 06:59:30 -0500 Subject: Re: [PATCH] qlogicpti: Return correct error code To: Amitoj Kaur Chawla , JBottomley@odin.com, martin.petersen@oracle.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org References: <20160217133254.GA31334@amitoj-Inspiron-3542> Cc: julia.lawall@lip6.fr From: Hannes Reinecke Message-ID: <56D58415.5090407@suse.de> Date: Tue, 1 Mar 2016 19:59:17 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <20160217133254.GA31334@amitoj-Inspiron-3542> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/17/2016 09:32 PM, Amitoj Kaur Chawla wrote: > The return value of of_ioremap on failure should be -ENODEV and not > -1. > > Found using Coccinelle. A simplified version of the semantic patch > used is: > > // > @@ > expression *e; > @@ > > e = of_ioremap(...); > if (e == NULL) { > ... > return > - -1 > + -ENODEV > ; > } > // > > The single call site only checks that the return value is less than 0, > hence no change is required at the call site. > > Signed-off-by: Amitoj Kaur Chawla > --- > drivers/scsi/qlogicpti.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/scsi/qlogicpti.c b/drivers/scsi/qlogicpti.c > index 676385f..69bfc0a 100644 > --- a/drivers/scsi/qlogicpti.c > +++ b/drivers/scsi/qlogicpti.c > @@ -710,7 +710,7 @@ static int qpti_map_regs(struct qlogicpti *qpti) > "PTI Qlogic/ISP"); > if (!qpti->qregs) { > printk("PTI: Qlogic/ISP registers are unmappable\n"); > - return -1; > + return -ENODEV; > } > if (qpti->is_pti) { > qpti->sreg = of_ioremap(&op->resource[0], (16 * 4096), > @@ -718,7 +718,7 @@ static int qpti_map_regs(struct qlogicpti *qpti) > "PTI Qlogic/ISP statreg"); > if (!qpti->sreg) { > printk("PTI: Qlogic/ISP status register is unmappable\n"); > - return -1; > + return -ENODEV; > } > } > return 0; > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage hare@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)