From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754388AbcCAPQz (ORCPT ); Tue, 1 Mar 2016 10:16:55 -0500 Received: from mga04.intel.com ([192.55.52.120]:64071 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753858AbcCAPQy (ORCPT ); Tue, 1 Mar 2016 10:16:54 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,523,1449561600"; d="scan'208";a="57644280" Subject: Re: [PATCH] KVM: Replace the number of page entries per page with PT64_ENT_PER_PAGE macro To: gleb@kernel.org, pbonzini@redhat.com, tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, x86@kernel.org References: <1456843758-2261-1-git-send-email-tianyu.lan@intel.com> Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org From: "Lan, Tianyu" Message-ID: <56D5B263.4060008@intel.com> Date: Tue, 1 Mar 2016 23:16:51 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <1456843758-2261-1-git-send-email-tianyu.lan@intel.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Sorry. Miss some other modifications and please ignore this version. On 3/1/2016 10:49 PM, Lan Tianyu wrote: > This patch is to make code more readable. > > Signed-off-by: Lan Tianyu > --- > arch/x86/include/asm/kvm_host.h | 2 +- > arch/x86/kvm/mmu.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/x86/include/asm/kvm_host.h b/arch/x86/include/asm/kvm_host.h > index 44adbb8..b91a08a 100644 > --- a/arch/x86/include/asm/kvm_host.h > +++ b/arch/x86/include/asm/kvm_host.h > @@ -265,7 +265,7 @@ struct kvm_mmu_page { > /* The page is obsolete if mmu_valid_gen != kvm->arch.mmu_valid_gen. */ > unsigned long mmu_valid_gen; > > - DECLARE_BITMAP(unsync_child_bitmap, 512); > + DECLARE_BITMAP(unsync_child_bitmap, PT64_ENT_PER_PAGE); > > #ifdef CONFIG_X86_32 > /* > diff --git a/arch/x86/kvm/mmu.c b/arch/x86/kvm/mmu.c > index 95a955d..d51441b 100644 > --- a/arch/x86/kvm/mmu.c > +++ b/arch/x86/kvm/mmu.c > @@ -1806,7 +1806,7 @@ static int __mmu_unsync_walk(struct kvm_mmu_page *sp, > { > int i, ret, nr_unsync_leaf = 0; > > - for_each_set_bit(i, sp->unsync_child_bitmap, 512) { > + for_each_set_bit(i, sp->unsync_child_bitmap, PT64_ENT_PER_PAGE) { > struct kvm_mmu_page *child; > u64 ent = sp->spt[i]; > >