From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756636AbcCBAHh (ORCPT ); Tue, 1 Mar 2016 19:07:37 -0500 Received: from mx2.suse.de ([195.135.220.15]:50799 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756441AbcCBAHd (ORCPT ); Tue, 1 Mar 2016 19:07:33 -0500 Subject: Re: [PATCH 7/8] ARM64: dts: amlogic: Extend GXBaby GIC node To: =?UTF-8?Q?Andr=c3=a9_Przywara?= , linux-meson@googlegroups.com References: <1456789465-2962-1-git-send-email-afaerber@suse.de> <1456789465-2962-8-git-send-email-afaerber@suse.de> <56D57673.8030702@arm.com> <56D57A7F.5020806@suse.de> <56D58E88.2080700@arm.com> <56D6264B.2090507@suse.de> <56D62DB8.2080301@arm.com> Cc: Mark Rutland , devicetree , Matthias Brugger , Pawel Moll , Ian Campbell , Catalin Marinas , Nicolas Saenz , Will Deacon , LKML , Rob Herring , Kumar Gala , Carlo Caione , linux-arm-kernel@lists.infradead.org From: =?UTF-8?Q?Andreas_F=c3=a4rber?= Organization: SUSE Linux GmbH Message-ID: <56D62EC1.7040100@suse.de> Date: Wed, 2 Mar 2016 01:07:29 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <56D62DB8.2080301@arm.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 02.03.2016 um 01:03 schrieb André Przywara: > On 01/03/16 23:31, Andreas Färber wrote: >> Am 01.03.2016 um 13:43 schrieb Andre Przywara: >>> On 01/03/16 11:18, Andreas Färber wrote: >>>> Am 01.03.2016 um 12:01 schrieb Andre Przywara: >>>>> On 29/02/16 23:44, Andreas Färber wrote: >>>>>> diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi >>>>>> index 0ae089bd1806..5088ae3ff653 100644 >>>>>> --- a/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi >>>>>> +++ b/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi >>>>>> @@ -117,7 +117,9 @@ >>>>>> gic: interrupt-controller@c4301000 { >>>>>> compatible = "arm,cortex-a15-gic", "arm,cortex-a9-gic"; >>>>> >>>>> I think "arm,gic-400" is the name to use here these days, especially for >>>>> arm64. >>>> >>>> I took what /proc/device-tree showed on Android and verified that this >>>> compatible is in use in mainline. >>> >>> Some vendor Android kernel is not a good reference for mainline work ;-) >>> Better look at other DTs in arch/arm64/boot/dts. >> >> Yes, that's what "in use in mainline" refers to: >> >> $ git grep "cortex-a15-gic" -- arch/arm64/boot/dts/ | grep -v gic-400 >> arch/arm64/boot/dts/apm/apm-shadowcat.dtsi: compatible = >> "arm,cortex-a15-gic"; >> arch/arm64/boot/dts/apm/apm-storm.dtsi: compatible = "arm,cortex-a15-gic"; >> arch/arm64/boot/dts/arm/foundation-v8.dts: compatible = >> "arm,cortex-a15-gic", "arm,cortex-a9-gic"; >> arch/arm64/boot/dts/arm/rtsm_ve-aemv8a.dts: compatible = >> "arm,cortex-a15-gic", "arm,cortex-a9-gic"; >> arch/arm64/boot/dts/nvidia/tegra132.dtsi: compatible = "arm,cortex-a15-gic"; > > Which is mainly because those DTs predate the introduction of > "arm,gic-400". Other DTs kept the cortex strings in additionally to stay > compatible with older kernels. Sure, but shouldn't we update them to have arm,gic-400 first then? >>> You could keep "arm,cortex-a15-gic" in there if you care about >>> compatibility with older (vendor) kernels, but I guess there are other >>> issues which prevent this anyway, so you could drop this as well. >> >> Yeah, I don't care about backwards compatibility with downstream >> kernels, they use weird compatible strings with spaces anyway. > > So please drop it and use only "arm,gic-400" to be in line with all the > other more recent SoCs. Already done, still inserting cbus/aobus nodes and moving uart nodes, then need to re-test. Cheers, Andreas -- SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Felix Imendörffer, Jane Smithard, Graham Norton; HRB 21284 (AG Nürnberg)