From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965636AbcCJKmv (ORCPT ); Thu, 10 Mar 2016 05:42:51 -0500 Received: from smtp105.iad3a.emailsrvr.com ([173.203.187.105]:34606 "EHLO smtp105.iad3a.emailsrvr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932829AbcCJKml (ORCPT ); Thu, 10 Mar 2016 05:42:41 -0500 X-Auth-ID: abbotti@mev.co.uk X-Sender-Id: abbotti@mev.co.uk Subject: Re: [PATCH 4/5] Staging: comedi: fix CHECK issue in ni_tio.c To: Ravishankar Karkala Mallikarjunayya References: <1457592730-14347-1-git-send-email-ravishankarkm32@gmail.com> <1457592730-14347-4-git-send-email-ravishankarkm32@gmail.com> Cc: hsweeten@visionengravers.com, gregkh@linuxfoundation.org, geliangtang@163.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org From: Ian Abbott Message-ID: <56E14F9E.1000803@mev.co.uk> Date: Thu, 10 Mar 2016 10:42:38 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Icedove/38.6.0 MIME-Version: 1.0 In-Reply-To: <1457592730-14347-4-git-send-email-ravishankarkm32@gmail.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/03/16 06:52, Ravishankar Karkala Mallikarjunayya wrote: > This is a patch to the ni_tio.c file that fixes up a CHECK issues > found by the checkpatch.pl tool. > > i.e. Avoid crashing the kernel - try using WARN_ON & recovery code > rather than BUG() or BUG_ON(). > > Signed-off-by: Ravishankar Karkala Mallikarjunayya > --- > drivers/staging/comedi/drivers/ni_tio.c | 18 +++++++++--------- > 1 file changed, 9 insertions(+), 9 deletions(-) Thanks! Reviewed-by: Ian Abbott -- -=( Ian Abbott @ MEV Ltd. E-mail: )=- -=( Web: http://www.mev.co.uk/ )=-