From: Laxman Dewangan <ldewangan@nvidia.com>
To: Mark Brown <broonie@kernel.org>
Cc: <robh+dt@kernel.org>, <pawel.moll@arm.com>, <lgirdwood@gmail.com>,
<lee.jones@linaro.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/5] regulator: pwm: Prints error number when it fails
Date: Sun, 13 Mar 2016 18:37:56 +0530 [thread overview]
Message-ID: <56E5662C.7020906@nvidia.com> (raw)
In-Reply-To: <20160312060543.GV3898@sirena.org.uk>
On Saturday 12 March 2016 11:35 AM, Mark Brown wrote:
> * PGP Signed by an unknown key
>
> On Tue, Mar 08, 2016 at 04:23:23PM +0530, Laxman Dewangan wrote:
>
>> + dev_err(&pdev->dev, "Failed to get PWM, %d\n", ret);
> Pretty much everywhere else in the kernel we use "foo: %d\n" - please
> use a consistent style.
I saw mixed approach and so always thought what would be better.
Great to know that it is foo: %d style is far better than other way.
Will correct and post the another patch.
next prev parent reply other threads:[~2016-03-13 13:21 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-08 10:53 [PATCH 0/5] regulator: pwm: Add supports for multiple instance and voltage linear steps Laxman Dewangan
2016-03-08 10:53 ` [PATCH 1/5] regulator: pwm: Fix calculation of voltage-to-duty cycle Laxman Dewangan
2016-03-08 10:53 ` [PATCH 2/5] regulator: pwm: Add support to have multiple instance of pwm regulator Laxman Dewangan
2016-03-08 10:53 ` [PATCH 3/5] regulator: pwm: Prints error number when it fails Laxman Dewangan
2016-03-12 6:05 ` Mark Brown
2016-03-13 13:07 ` Laxman Dewangan [this message]
2016-03-08 10:53 ` [PATCH 4/5] regulator: pwm: Add support for voltage linear equal steps Laxman Dewangan
2016-03-12 6:09 ` Mark Brown
2016-03-13 13:06 ` Laxman Dewangan
2016-03-14 16:28 ` Mark Brown
2016-03-15 6:44 ` Laxman Dewangan
2016-03-08 10:53 ` [PATCH 5/5] regulator: pwm: Add DT binding details for Linear Equal Step Mode Laxman Dewangan
2016-03-17 15:27 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56E5662C.7020906@nvidia.com \
--to=ldewangan@nvidia.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome