From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755064AbcCNHWG (ORCPT ); Mon, 14 Mar 2016 03:22:06 -0400 Received: from mx2.suse.de ([195.135.220.15]:54955 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754951AbcCNHV6 (ORCPT ); Mon, 14 Mar 2016 03:21:58 -0400 Subject: Re: [PATCH 02/22] ncr5380: Remove FLAG_NO_PSEUDO_DMA where possible To: Finn Thain , "James E.J. Bottomley" , "Martin K. Petersen" , Michael Schmitz , linux-m68k@vger.kernel.org, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org References: <20160314042700.596192247@telegraphics.com.au> <20160314042701.115991238@telegraphics.com.au> Cc: Ondrej Zary , Sam Creasey From: Hannes Reinecke Message-ID: <56E66693.1090901@suse.de> Date: Mon, 14 Mar 2016 08:21:55 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <20160314042701.115991238@telegraphics.com.au> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/14/2016 05:27 AM, Finn Thain wrote: > Drivers that define PSEUDO_DMA also define NCR5380_dma_xfer_len. > The core driver must call NCR5380_dma_xfer_len which means > FLAG_NO_PSEUDO_DMA can be eradicated from the core driver. > > dmx3191d doesn't define PSEUDO_DMA and has no use for FLAG_NO_PSEUDO_DMA, > so remove it there also. > > Signed-off-by: Finn Thain > > --- > drivers/scsi/NCR5380.c | 3 +-- > drivers/scsi/dmx3191d.c | 2 +- > drivers/scsi/g_NCR5380.c | 7 ++++++- > drivers/scsi/g_NCR5380.h | 2 +- > drivers/scsi/mac_scsi.c | 15 ++++++++++++++- > 5 files changed, 23 insertions(+), 6 deletions(-) > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke Teamlead Storage & Networking hare@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg)